Code review updates

scottshambaugh · scottshambaugh · commit 5604109bdd6f · 2026-02-03T14:59:19.000-07:00
diff --git a/lib/matplotlib/image.py b/lib/matplotlib/image.py
@@ -905,7 +905,7 @@ def __init__(self, ax,
 
     def get_window_extent(self, renderer=None):
         x0, x1, y0, y1 = self._extent
-        bbox = Bbox.from_extents(x0, y0, x1, y1)
+        bbox = Bbox.from_extents([x0, y0, x1, y1])
         return bbox.transformed(self.get_transform())
 
     def make_image(self, renderer, magnification=1.0, unsampled=False):
diff --git a/lib/matplotlib/lines.py b/lib/matplotlib/lines.py
@@ -683,15 +683,11 @@ def recache(self, always=False):
         else:
             y = self._y
 
-        # Fast path for common case where x and y have same shape
-        if x.shape == y.shape:
-            self._xy = np.empty((x.size, 2), dtype=float)
-            self._xy[:, 0] = x
-            self._xy[:, 1] = y
-        else:
-            self._xy = np.column_stack(np.broadcast_arrays(x, y)).astype(float)
-        self._x = self._xy[:, 0]  # view
-        self._y = self._xy[:, 1]  # view
+        self._xy = np.empty((max(len(x), len(y)), 2), dtype=float)
+        self._xy[:, 0] = x  # broadcast x and y to the same shape
+        self._xy[:, 1] = y
+        self._x = self._xy[:, 0]  # views of the x and y data
+        self._y = self._xy[:, 1]
 
         self._subslice = False
         if (self.axes
diff --git a/lib/matplotlib/transforms.py b/lib/matplotlib/transforms.py
@@ -841,10 +841,7 @@ def from_extents(*args, minpos=None):
             set. This is useful when dealing with logarithmic scales and other
             scales where negative bounds result in floating point errors.
         """
-        if len(args) == 4:
-            bbox = Bbox(np.array([[args[0], args[1]], [args[2], args[3]]], dtype=float))
-        else:
-            bbox = Bbox(np.reshape(args, (2, 2)))
+        bbox = Bbox(np.asarray(args, dtype=float).reshape((2, 2)))
         if minpos is not None:
             bbox._minpos[:] = minpos
         return bbox
