Merge pull request #18091 from QuLogic/flake8

dopplershift · web-flow · commit 560ccffce320 · 2020-07-28T07:20:14.000-06:00
ci: Fix linting being ignored by reviewdog
diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml
@@ -29,7 +29,8 @@ jobs:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           flake8 --docstring-convention=all | \
-            reviewdog -f=pep8 -name=flake8 -reporter=github-check
+            reviewdog -f=pep8 -name=flake8 \
+              -tee -reporter=github-check -filter-mode nofilter
 
   eslint:
     name: eslint
@@ -40,6 +41,7 @@ jobs:
       - name: eslint
         uses: reviewdog/action-eslint@v1
         with:
+          filter_mode: nofilter
           github_token: ${{ secrets.GITHUB_TOKEN }}
           reporter: github-check
           workdir: 'lib/matplotlib/backends/web_backend/'
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -830,8 +830,8 @@ def axhline(self, y=0, xmin=0, xmax=1, **kwargs):
         """
         self._check_no_units([xmin, xmax], ['xmin', 'xmax'])
         if "transform" in kwargs:
-            raise ValueError("'transform' is not allowed as a keyword argument; "
-                             "axhline generates its own transform.")
+            raise ValueError("'transform' is not allowed as a keyword "
+                             "argument; axhline generates its own transform.")
         ymin, ymax = self.get_ybound()
 
         # We need to strip away the units for comparison with
@@ -899,8 +899,8 @@ def axvline(self, x=0, ymin=0, ymax=1, **kwargs):
         """
         self._check_no_units([ymin, ymax], ['ymin', 'ymax'])
         if "transform" in kwargs:
-            raise ValueError("'transform' is not allowed as a keyword argument; "
-                             "axvline generates its own transform.")
+            raise ValueError("'transform' is not allowed as a keyword "
+                             "argument; axvline generates its own transform.")
         xmin, xmax = self.get_xbound()
 
         # We need to strip away the units for comparison with
diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py
@@ -18,7 +18,6 @@
 import logging
 from numbers import Number
 import operator
-import os
 import re
 
 import numpy as np
