Merge pull request #28196 from tacaswell/tst/add_timeouts

ksunden · web-flow · commit 5673e336aa6e · 2024-05-24T12:25:57.000-05:00
TST: add timeouts to font_manager + threading test
diff --git a/lib/matplotlib/tests/test_font_manager.py b/lib/matplotlib/tests/test_font_manager.py
@@ -253,11 +253,16 @@ def _test_threading():
     from matplotlib.ft2font import LOAD_NO_HINTING
     import matplotlib.font_manager as fm
 
+    def loud_excepthook(args):
+        raise RuntimeError("error in thread!")
+
+    threading.excepthook = loud_excepthook
+
     N = 10
     b = threading.Barrier(N)
 
     def bad_idea(n):
-        b.wait()
+        b.wait(timeout=5)
         for j in range(100):
             font = fm.get_font(fm.findfont("DejaVu Sans"))
             font.set_text(str(n), 0.0, flags=LOAD_NO_HINTING)
@@ -271,7 +276,9 @@ def bad_idea(n):
         t.start()
 
     for t in threads:
-        t.join()
+        t.join(timeout=9)
+        if t.is_alive():
+            raise RuntimeError("thread failed to join")
 
 
 def test_fontcache_thread_safe():
