updating inline with review comments

McCoubs · McCoubs · commit 56a751248743 · 2020-05-06T18:58:53.000-04:00
fixing flake8 errors

updating inline with reviewer comments

updating inline with reviewer comments
diff --git a/doc/api/api_changes_3.3/behaviour.rst b/doc/api/api_changes_3.3/behaviour.rst
@@ -275,16 +275,8 @@ instead of ::
     <a list of 3 Lists of Patches objects>  # "bar", "barstacked"
     <a list of 3 Lists of Patches objects>  # "step", "stepfilled"
 
-`Axes.vlines` and `Axes.hlines` `color` parameter will now default to configured rcparams `lines.color`
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-Previously the `color` parameter in `Axes.vlines` and `Axes.hlines` would always default to 'k' if not provided.
-This was inconsistent with the rest of the API and now `color` will instead default to the configured rcparam's
-`lines.color` value, falling back to 'k' if necessary.
 
-`pyplot.vlines` and `pyplot.hlines` `color` parameter will now default to configured rcparams `lines.color`
+`.Axes.vlines`, `.Axes.hlines`, `.pyplot.vlines` and `.pyplot.hlines` *colors* parameter default change
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Previously the `color` parameter in `pyplot.vlines` and `pyplot.hlines` would always default to 'k' if not provided.
-This was inconsistent with the rest of the API and now `color` will instead default to the configured rcparam's
-`lines.color` value, falling back to 'k' if necessary.
+The *colors* parameter will now default to :rc:`lines.color`, while previously it defaulted to 'k'.
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -1130,7 +1130,7 @@ def hlines(self, y, xmin, xmax, colors=None, linestyles='solid',
             Respective beginning and end of each line. If scalars are
             provided, all lines will have same length.
 
-        colors : array-like of colors, default: None
+        colors : array-like of colors, default: :rc:`lines.color`
 
         linestyles : {'solid', 'dashed', 'dashdot', 'dotted'}, optional
 
@@ -1157,8 +1157,6 @@ def hlines(self, y, xmin, xmax, colors=None, linestyles='solid',
         xmin = self.convert_xunits(xmin)
         xmax = self.convert_xunits(xmax)
 
-        colors = rcParams['lines.color'] or 'k' if colors is None else colors
-
         if not np.iterable(y):
             y = [y]
         if not np.iterable(xmin):
@@ -1214,7 +1212,7 @@ def vlines(self, x, ymin, ymax, colors=None, linestyles='solid',
             Respective beginning and end of each line. If scalars are
             provided, all lines will have same length.
 
-        colors : array-like of colors, default: None
+        colors : array-like of colors, default: :rc:`lines.color`
 
         linestyles : {'solid', 'dashed', 'dashdot', 'dotted'}, optional
 
@@ -1241,8 +1239,6 @@ def vlines(self, x, ymin, ymax, colors=None, linestyles='solid',
         ymin = self.convert_yunits(ymin)
         ymax = self.convert_yunits(ymax)
 
-        colors = rcParams['lines.color'] or 'k' if colors is None else colors
-
         if not np.iterable(x):
             x = [x]
         if not np.iterable(ymin):
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -3790,7 +3790,7 @@ def test_vlines_default(fig_test, fig_ref):
     ax_test = fig_test.subplots()
     ax_ref = fig_ref.subplots()
 
-    # compare constructing the reference with given value to configured rcParams on test
+    # compare constructing ref with given value to configured rcParams on test
     ax_ref.vlines(0.5, 0, 1, colors='red')
     with mpl.rc_context({'lines.color': 'red'}):
         ax_test.vlines(0.5, 0, 1)
@@ -3841,7 +3841,7 @@ def test_hlines_default(fig_test, fig_ref):
     ax_test = fig_test.subplots()
     ax_ref = fig_ref.subplots()
 
-    # compare constructing the reference with given value to configured rcParams on test
+    # compare constructing ref with given value to configured rcParams on test
     ax_ref.hlines(0.5, 0, 1, colors='red')
     with mpl.rc_context({'lines.color': 'red'}):
         ax_test.hlines(0.5, 0, 1)
