FIXes: make sure we don't call if not in layout

jklymak · jklymak · commit 5ca5d6c88720 · 2019-05-11T17:20:24.000-07:00
diff --git a/lib/matplotlib/_constrained_layout.py b/lib/matplotlib/_constrained_layout.py
@@ -175,14 +175,22 @@ def do_constrained_layout(fig, renderer, h_pad, w_pad,
                 _make_layout_margins(ax, renderer, h_pad, w_pad)
 
         # do layout for suptitle.
-        do_sup = (fig._suptitle is not None and
-            fig._suptitle._layoutbox is not None)
-        if do_sup:
-            sup = fig._suptitle
-            bbox = invTransFig(sup.get_window_extent(renderer=renderer))
+        suptitle = fig._suptitle
+        print(suptitle)
+        do_suptitle = (suptitle is None or
+                       suptitle._layoutbox is  None or
+                       not suptitle.get_in_layout())
+        do_suptitle = not do_suptitle
+        if do_suptitle:
+            suptitle = fig._suptitle
+            bbox = invTransFig(
+                suptitle.get_window_extent(renderer=renderer))
             height = bbox.y1 - bbox.y0
             if np.isfinite(height):
-                sup._layoutbox.edit_height(height + h_pad * 2)
+                # reserve at top of figure include an h_pad above and below
+                suptitle._layoutbox.edit_height(height + h_pad * 2)
+        else:
+            do_suptitle = False
 
         # OK, the above lines up ax._poslayoutbox with ax._layoutbox
         # now we need to
@@ -223,9 +231,12 @@ def do_constrained_layout(fig, renderer, h_pad, w_pad,
                     # this axis, allowing users to hard-code the position,
                     # so this does the same w/o zeroing layout.
                     ax._set_position(newpos, which='original')
-            if do_sup:
-                newpos = sup._layoutbox.get_rect()
-                sup.set_y(newpos[1] + newpos[3] - h_pad)
+            if do_suptitle:
+                newpos = suptitle._layoutbox.get_rect()
+                suptitle.set_y(1.0 - h_pad)
+            else:
+                if suptitle is not None and suptitle._layoutbox is not None:
+                    suptitle._layoutbox.edit_height(0)
 
         else:
             cbook._warn_external('constrained_layout not applied.  At least '
