TST: Correctly skip missing distillers

QuLogic · QuLogic · commit 5d0ec0e06e65 · 2023-08-09T17:13:39.000-04:00
When a distiller is not found, that step is simply skipped by
`_try_distill`, so these tests were not actually skipped as intended.
diff --git a/lib/matplotlib/tests/test_backend_ps.py b/lib/matplotlib/tests/test_backend_ps.py
@@ -40,6 +40,17 @@
     'eps with usetex'
 ])
 def test_savefig_to_stringio(format, use_log, rcParams, orientation, papersize):
+    if rcParams.get("ps.usedistiller") == "ghostscript":
+        try:
+            mpl._get_executable_info("gs")
+        except mpl.ExecutableNotFoundError as exc:
+            pytest.skip(str(exc))
+    elif rcParams.get("ps.userdistiller") == "xpdf":
+        try:
+            mpl._get_executable_info("pdftops")
+        except mpl.ExecutableNotFoundError as exc:
+            pytest.skip(str(exc))
+
     mpl.rcParams.update(rcParams)
 
     fig, ax = plt.subplots()
@@ -55,8 +66,6 @@ def test_savefig_to_stringio(format, use_log, rcParams, orientation, papersize):
             title += " \N{MINUS SIGN}\N{EURO SIGN}"
         ax.set_title(title)
         allowable_exceptions = []
-        if rcParams.get("ps.usedistiller"):
-            allowable_exceptions.append(mpl.ExecutableNotFoundError)
         if rcParams.get("text.usetex"):
             allowable_exceptions.append(RuntimeError)
         if rcParams.get("ps.useafm"):
