Merge pull request #12700 from timhoffm/auto-backport-of-pr-12653-on-v3.0.x

dstansby · web-flow · commit 6080c2163e39 · 2018-11-01T17:05:40.000+01:00
Backport PR #12653: Don't warn when accessing deprecated properties f…
diff --git a/lib/matplotlib/cbook/deprecation.py b/lib/matplotlib/cbook/deprecation.py
@@ -190,6 +190,36 @@ def finalize(wrapper, new_doc):
                 obj.__doc__ = new_doc
                 obj.__init__ = wrapper
                 return obj
+
+        elif isinstance(obj, property):
+            obj_type = "attribute"
+            func = None
+            name = name or obj.fget.__name__
+            old_doc = obj.__doc__
+
+            class _deprecated_property(property):
+                def __get__(self, instance, owner):
+                    if instance is not None:
+                        from . import _warn_external
+                        _warn_external(message, category)
+                    return super().__get__(instance, owner)
+
+                def __set__(self, instance, value):
+                    if instance is not None:
+                        from . import _warn_external
+                        _warn_external(message, category)
+                    return super().__set__(instance, value)
+
+                def __delete__(self, instance):
+                    if instance is not None:
+                        from . import _warn_external
+                        _warn_external(message, category)
+                    return super().__delete__(instance)
+
+            def finalize(_, new_doc):
+                return _deprecated_property(
+                    fget=obj.fget, fset=obj.fset, fdel=obj.fdel, doc=new_doc)
+
         else:
             obj_type = "function"
             if isinstance(obj, classmethod):
