Validate Line2D pickradius when setting it, not when reading i… (#16134)

anntzer · web-flow · commit 60cb0314ec04 · 2020-01-08T01:14:58.000+01:00
Validate Line2D pickradius when setting it, not when reading it.
diff --git a/lib/matplotlib/lines.py b/lib/matplotlib/lines.py
@@ -444,9 +444,6 @@ def contains(self, mouseevent):
         if inside is not None:
             return inside, info
 
-        if not isinstance(self.pickradius, Number):
-            raise ValueError("pick radius should be a distance")
-
         # Make sure we have data to plot
         if self._invalidy or self._invalidx:
             self.recache()
@@ -495,7 +492,7 @@ def get_pickradius(self):
 
         See `.contains` for more details.
         """
-        return self.pickradius
+        return self._pickradius
 
     def set_pickradius(self, d):
         """Set the pick radius used for containment tests.
@@ -507,7 +504,11 @@ def set_pickradius(self, d):
         d : float
             Pick radius, in points.
         """
-        self.pickradius = d
+        if not isinstance(d, Number) or d < 0:
+            raise ValueError("pick radius should be a distance")
+        self._pickradius = d
+
+    pickradius = property(get_pickradius, set_pickradius)
 
     def get_fillstyle(self):
         """
