Use __set_name__ for better wrapping.

anntzer · anntzer · commit 61c99b6d5030 · 2020-04-04T14:05:28.000+02:00
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -1,6 +1,5 @@
 from collections import OrderedDict
 from contextlib import ExitStack
-import functools
 import inspect
 import itertools
 import logging
@@ -49,14 +48,17 @@ def _axis_method_wrapper(attr_name, method_name, *, doc_sub=None):
     dedented to simplify further manipulations.
     """
 
-    method = getattr(maxis.Axis, method_name)
     get_method = attrgetter(f"{attr_name}.{method_name}")
 
-    @functools.wraps(method)
     def wrapper(self, *args, **kwargs):
         return get_method(self)(*args, **kwargs)
 
-    doc = wrapper.__doc__
+    # Manually copy the signature instead of using functools.wraps because
+    # displaying the Axis method source when asking for the Axes method source
+    # would be confusing.
+    wrapped_method = getattr(maxis.Axis, method_name)
+    wrapper.__signature__ = inspect.signature(wrapped_method)
+    doc = wrapped_method.__doc__
     if doc:
         doc_sub = {"this Axis": f"the {attr_name}", **(doc_sub or {})}
         for k, v in doc_sub.items():
@@ -66,7 +68,14 @@ def wrapper(self, *args, **kwargs):
             doc = doc.replace(k, v)
         wrapper.__doc__ = inspect.cleandoc(doc)
 
-    return wrapper
+    class Placeholder:
+        def __set_name__(self, owner, name):
+            wrapper.__module__ = owner.__module__
+            wrapper.__name__ = name
+            wrapper.__qualname__ = f"{owner.__qualname__}.{name}"
+            setattr(owner, name, wrapper)
+
+    return Placeholder()
 
 
 def _process_plot_format(fmt):
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -829,7 +829,7 @@ def set_zscale(self, value, **kwargs):
     get_zticklabels = _axis_method_wrapper("zaxis", "get_ticklabels")
     set_zticklabels = _axis_method_wrapper(
         "zaxis", "_set_ticklabels",
-        doc_sub={"Axis.set_ticks": "Axes.set_zticks"})
+        doc_sub={"Axis.set_ticks": "Axes3D.set_zticks"})
 
     zaxis_date = _axis_method_wrapper("zaxis", "axis_date")
     if zaxis_date.__doc__:
