Add key release and continue refactoring state handling

blink1073 · blink1073 · commit 623e05d9402f · 2014-12-20T14:13:32.000-06:00
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -1119,7 +1119,7 @@ def __init__(self, ax, onselect, useblit=False, button=None):
         # will save the data (pos. at mouserelease)
         self.eventrelease = None
         self._prev_event = None
-        self.state = []
+        self.state = set()
 
     def set_active(self, active):
         AxesWidget.set_active(self, active)
@@ -1140,6 +1140,7 @@ def connect_default_events(self):
         self.connect_event('button_release_event', self._release)
         self.connect_event('draw_event', self.update_background)
         self.connect_event('key_press_event', self._on_key_press)
+        self.connect_event('key_release_event', self._on_key_release)
         self.connect_event('scroll_event', self._on_scroll)
 
     def ignore(self, event):
@@ -1220,15 +1221,9 @@ def _press(self, event):
             event = self._clean_event(event)
             self.eventpress = event
             self._prev_event = event
-
-            self.state = []
             key = event.key or ''
             if 'alt' in key or key == ' ':
-                self.state.append('move')
-            if 'shift' in key:
-                self.state.append('square')
-            if 'ctrl' in key or 'control' in key:
-                self.state.append('center')
+                self.state.add('move')
             self.press(event)
 
     def press(self, event):
@@ -1250,16 +1245,6 @@ def _onmove(self, event):
         """Cursor move event handler and validator"""
         if not self.ignore(event) and self.eventpress:
             event = self._clean_event(event)
-            # update the state
-            if 'move' in self.state:
-                self.state = ['move']
-            else:
-                self.state = []
-            key = event.key or ''
-            if 'shift' in key:
-                self.state.append('square')
-            if 'ctrl' in key or 'control' in key:
-                self.state.append('center')
             self.onmove(event)
 
     def onmove(self, event):
@@ -1277,13 +1262,32 @@ def on_scroll(self, event):
 
     def _on_key_press(self, event):
         """Key press event handler and validator"""
-        if not self.ignore(event):
+        if self.active:
+            key = event.key or ''
+            if 'shift' in key:
+                self.state.add('square')
+            if 'ctrl' in key or 'control' in key:
+                self.state.add('center')
             self.on_key_press(event)
 
     def on_key_press(self, event):
         """Key press event handler"""
         pass
 
+    def _on_key_release(self, event):
+        """Key release event handler and validator"""
+        if self.active:
+            key = event.key or ''
+            if 'shift' in key:
+                self.state.discard('square')
+            if 'ctrl' in key or 'control' in key:
+                self.state.discard('center')
+            self.on_key_release(event)
+
+    def on_key_release(self, event):
+        """Key release event handler"""
+        pass
+
     def set_visible(self, visible):
         """ Set the visibility of our artists """
         self.visible = visible
