Warn if activecolor and a facecolor are provided

QuLogic · QuLogic · commit 6319ba97b24d · 2023-01-19T14:48:35.000-05:00
diff --git a/lib/matplotlib/tests/test_widgets.py b/lib/matplotlib/tests/test_widgets.py
@@ -1034,6 +1034,15 @@ def test_radio_buttons_props(fig_test, fig_ref):
     cb.set_radio_props({**radio_props, 's': (24 / 2)**2})
 
 
+def test_radio_button_active_conflict(ax):
+    with pytest.warns(UserWarning,
+                      match=r'Both the \*activecolor\* parameter'):
+        rb = widgets.RadioButtons(ax, ['tea', 'coffee'], activecolor='red',
+                                  radio_props={'facecolor': 'green'})
+    # *radio_props*' facecolor wins over *activecolor*
+    assert mcolors.same_color(rb._buttons.get_facecolor(), ['green', 'none'])
+
+
 @check_figures_equal(extensions=["png"])
 def test_check_buttons(fig_test, fig_ref):
     widgets.CheckButtons(fig_test.subplots(), ["tea", "coffee"], [True, True])
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -1596,7 +1596,7 @@ class RadioButtons(AxesWidget):
         The label text of the currently selected button.
     """
 
-    def __init__(self, ax, labels, active=0, activecolor='blue', *,
+    def __init__(self, ax, labels, active=0, activecolor=None, *,
                  useblit=True, label_props=None, radio_props=None):
         """
         Add radio buttons to an `~.axes.Axes`.
@@ -1610,12 +1610,8 @@ def __init__(self, ax, labels, active=0, activecolor='blue', *,
         active : int
             The index of the initially selected button.
         activecolor : color
-            The color of the selected button.
-
-            .. note::
-                If a facecolor is supplied in *radio_props*, it will override
-                *activecolor*. This may be used to provide an active color per
-                button.
+            The color of the selected button. The default is ``'blue'`` if not
+            specified here or in *radio_props*.
         useblit : bool, default: True
             Use blitting for faster drawing if supported by the backend.
             See the tutorial :doc:`/tutorials/advanced/blitting` for details.
@@ -1632,6 +1628,21 @@ def __init__(self, ax, labels, active=0, activecolor='blue', *,
                 button.
         """
         super().__init__(ax)
+
+        _api.check_isinstance((dict, None), label_props=label_props,
+                              radio_props=radio_props)
+
+        radio_props = cbook.normalize_kwargs(radio_props,
+                                             collections.PathCollection)
+        if activecolor is not None:
+            if 'facecolor' in radio_props:
+                _api.warn_external(
+                    'Both the *activecolor* parameter and the *facecolor* '
+                    'key in the *radio_props* parameter has been specified. '
+                    '*activecolor* will be ignored.')
+        else:
+            activecolor = 'blue'  # Default.
+
         self.activecolor = activecolor
         self.value_selected = labels[active]
 
@@ -1644,9 +1655,6 @@ def __init__(self, ax, labels, active=0, activecolor='blue', *,
         self._useblit = useblit and self.canvas.supports_blit
         self._background = None
 
-        _api.check_isinstance((dict, None), label_props=label_props,
-                              radio_props=radio_props)
-
         label_props = _expand_text_props(label_props)
         self.labels = [
             ax.text(0.25, y, label, transform=ax.transAxes,
@@ -1660,7 +1668,7 @@ def __init__(self, ax, labels, active=0, activecolor='blue', *,
             's': text_size**2,
             'facecolor': activecolor,
             'edgecolor': 'black',
-            **cbook.normalize_kwargs(radio_props, collections.PathCollection),
+            **radio_props,
             'transform': ax.transAxes,
             'animated': self._useblit,
         }
