Deprecate NavigationToolbar2GTK3.ctx.

anntzer · anntzer · commit 66e6842e62a4 · 2019-01-10T11:48:26.000+01:00
No alternative documented: messing with the window cairo context is
quite low level; if you're doing that, creating the context should not
be that hard.
diff --git a/doc/api/next_api_changes/2018-01-11-AL.rst b/doc/api/next_api_changes/2018-01-11-AL.rst
@@ -0,0 +1,4 @@
+Deprecations
+````````````
+
+The ``NavigationToolbar2GTK3.ctx`` attribute is deprecated.
diff --git a/lib/matplotlib/backends/backend_gtk3.py b/lib/matplotlib/backends/backend_gtk3.py
@@ -473,7 +473,11 @@ def __init__(self, canvas, window):
         self.win = window
         GObject.GObject.__init__(self)
         NavigationToolbar2.__init__(self, canvas)
-        self.ctx = None
+
+    @cbook.deprecated("3.1")
+    @property
+    def ctx(self):
+        return self.canvas.get_property("window").cairo_create()
 
     def set_message(self, s):
         self.message.set_label(s)
@@ -484,7 +488,7 @@ def set_cursor(self, cursor):
 
     def draw_rubberband(self, event, x0, y0, x1, y1):
         'adapted from http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/189744'
-        self.ctx = self.canvas.get_property("window").cairo_create()
+        ctx = self.canvas.get_property("window").cairo_create()
 
         # todo: instead of redrawing the entire figure, copy the part of
         # the figure that was covered by the previous rubberband rectangle
@@ -497,11 +501,11 @@ def draw_rubberband(self, event, x0, y0, x1, y1):
         h = abs(y1 - y0)
         rect = [int(val) for val in (min(x0, x1), min(y0, y1), w, h)]
 
-        self.ctx.new_path()
-        self.ctx.set_line_width(0.5)
-        self.ctx.rectangle(rect[0], rect[1], rect[2], rect[3])
-        self.ctx.set_source_rgb(0, 0, 0)
-        self.ctx.stroke()
+        ctx.new_path()
+        ctx.set_line_width(0.5)
+        ctx.rectangle(*rect)
+        ctx.set_source_rgb(0, 0, 0)
+        ctx.stroke()
 
     def _init_toolbar(self):
         self.set_style(Gtk.ToolbarStyle.ICONS)
