Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 68ed8e6

Browse files
committed
Expire numdecs deprecation
1 parent f621b01 commit 68ed8e6

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

lib/matplotlib/tests/test_ticker.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -362,15 +362,12 @@ def test_switch_to_autolocator(self):
362362
def test_set_params(self):
363363
"""
364364
Create log locator with default value, base=10.0, subs=[1.0],
365-
numdecs=4, numticks=15 and change it to something else.
365+
numticks=15 and change it to something else.
366366
See if change was successful. Should not raise exception.
367367
"""
368368
loc = mticker.LogLocator()
369-
with pytest.warns(mpl.MatplotlibDeprecationWarning, match="numdecs"):
370-
loc.set_params(numticks=7, numdecs=8, subs=[2.0], base=4)
369+
loc.set_params(numticks=7, subs=[2.0], base=4)
371370
assert loc.numticks == 7
372-
with pytest.warns(mpl.MatplotlibDeprecationWarning, match="numdecs"):
373-
assert loc.numdecs == 8
374371
assert loc._base == 4
375372
assert list(loc._subs) == [2.0]
376373

lib/matplotlib/ticker.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2275,8 +2275,7 @@ class LogLocator(Locator):
22752275
Places ticks at the values ``subs[j] * base**i``.
22762276
"""
22772277

2278-
@_api.delete_parameter("3.8", "numdecs")
2279-
def __init__(self, base=10.0, subs=(1.0,), numdecs=4, numticks=None):
2278+
def __init__(self, base=10.0, subs=(1.0,), numticks=None):
22802279
"""
22812280
Parameters
22822281
----------
@@ -2305,24 +2304,17 @@ def __init__(self, base=10.0, subs=(1.0,), numdecs=4, numticks=None):
23052304
numticks = 'auto'
23062305
self._base = float(base)
23072306
self._set_subs(subs)
2308-
self._numdecs = numdecs
23092307
self.numticks = numticks
23102308

2311-
@_api.delete_parameter("3.8", "numdecs")
2312-
def set_params(self, base=None, subs=None, numdecs=None, numticks=None):
2309+
def set_params(self, base=None, subs=None, numticks=None):
23132310
"""Set parameters within this locator."""
23142311
if base is not None:
23152312
self._base = float(base)
23162313
if subs is not None:
23172314
self._set_subs(subs)
2318-
if numdecs is not None:
2319-
self._numdecs = numdecs
23202315
if numticks is not None:
23212316
self.numticks = numticks
23222317

2323-
numdecs = _api.deprecate_privatize_attribute(
2324-
"3.8", addendum="This attribute has no effect.")
2325-
23262318
def _set_subs(self, subs):
23272319
"""
23282320
Set the minor ticks for the log scaling every ``base**i*subs[j]``.

lib/matplotlib/ticker.pyi

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,20 +231,17 @@ class MaxNLocator(Locator):
231231
def view_limits(self, dmin: float, dmax: float) -> tuple[float, float]: ...
232232

233233
class LogLocator(Locator):
234-
numdecs: float
235234
numticks: int | None
236235
def __init__(
237236
self,
238237
base: float = ...,
239238
subs: None | Literal["auto", "all"] | Sequence[float] = ...,
240-
numdecs: float = ...,
241239
numticks: int | None = ...,
242240
) -> None: ...
243241
def set_params(
244242
self,
245243
base: float | None = ...,
246244
subs: Literal["auto", "all"] | Sequence[float] | None = ...,
247-
numdecs: float | None = ...,
248245
numticks: int | None = ...,
249246
) -> None: ...
250247

0 commit comments

Comments
 (0)