TST: Wrap urlopen in a context manager as well

QuLogic · QuLogic · commit 6b5bc461bdfc · 2026-04-15T23:07:46.000-04:00
Just to be on the safe side that it closes.
diff --git a/lib/matplotlib/tests/test_backends_interactive.py b/lib/matplotlib/tests/test_backends_interactive.py
@@ -497,14 +497,14 @@ def test_webagg():
                     retcode = proc.poll()
                     # check that the subprocess for the server is not dead
                     assert retcode is None
-                    conn = urllib.request.urlopen(url)
-                    break
+                    with urllib.request.urlopen(url):
+                        # Do nothing; we've just confirmed that we can connect.
+                        break
                 except urllib.error.URLError:
                     if time.perf_counter() > timeout:
                         pytest.fail("Failed to connect to the webagg server.")
                     else:
                         continue
-            conn.close()
             proc.send_signal(signal.SIGINT)
             assert proc.wait(timeout=_test_timeout) == 0
         finally:
