FIX: move titles up if overlap axes

jklymak · jklymak · commit 7108a60c46f7 · 2018-07-02T09:08:34.000-07:00
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -2470,34 +2470,47 @@ def _update_title_position(self, renderer):
                 x, y = title.get_position()
                 if not np.isclose(y, 1.0):
                     self._autotitlepos = False
-                    _log.debug('not adjusting title pos because title was'
+                    _log.debug('not adjusting title pos because a title was'
                              ' already placed manually: %f', y)
                     return
             self._autotitlepos = True
 
+        ymax = -10
         for title in titles:
             x, y0 = title.get_position()
-            y = 1.0
+            y = y0
+            bt = title.get_window_extent(renderer)
             # need to check all our twins too...
             axs = self._twinned_axes.get_siblings(self)
 
             for ax in axs:
                 try:
+                    bb = ax.get_window_extent(renderer)
                     if (ax.xaxis.get_label_position() == 'top'
                             or ax.xaxis.get_ticks_position() == 'top'):
-                        bb = ax.xaxis.get_tightbbox(renderer)
-                        top = bb.ymax
-                        # we don't need to pad because the padding is already
-                        # in __init__: titleOffsetTrans
-                        yn = self.transAxes.inverted().transform((0., top))[1]
-                        y = max(y, yn)
+                        bb = mtransforms.Bbox.union([bb,
+                                ax.xaxis.get_tightbbox(renderer)])
+                    # need to do twice to get right for manual resizing
+                    dy = bt.ymin - bb.ymax
+                    if dy < 0:
+                        y = self.transAxes.inverted().transform(
+                                (0., bb.ymax - dy))[1]
+                        title.set_position((x, y))
+                        #bt = title.get_window_extent(renderer)
                 except AttributeError:
-                    pass
+                    y = 1
+            ymax = np.max((y, ymax))
+        for title in titles:
+            # now line up all the titles at the highest baseline.
+            x, y0 = title.get_position()
+            title.set_position((x, ymax))
+
+
 
-            title.set_position((x, y))
 
-    # Drawing
 
+
+    # Drawing
     @allow_rasterization
     def draw(self, renderer=None, inframe=False):
         """Draw everything (plot lines, axes, labels)"""
@@ -4133,19 +4146,19 @@ def get_tightbbox(self, renderer, call_axes_locator=True):
         if bb_xaxis:
             bb.append(bb_xaxis)
 
-        self._update_title_position(renderer)
-        bb.append(self.get_window_extent(renderer))
+        bb_yaxis = self.yaxis.get_tightbbox(renderer)
+        if bb_yaxis:
+            bb.append(bb_yaxis)
 
+        self._update_title_position(renderer)
         if self.title.get_visible():
             bb.append(self.title.get_window_extent(renderer))
         if self._left_title.get_visible():
             bb.append(self._left_title.get_window_extent(renderer))
         if self._right_title.get_visible():
             bb.append(self._right_title.get_window_extent(renderer))
 
-        bb_yaxis = self.yaxis.get_tightbbox(renderer)
-        if bb_yaxis:
-            bb.append(bb_yaxis)
+        bb.append(self.get_window_extent(renderer))
 
         for child in self.get_children():
             if isinstance(child, OffsetBox) and child.get_visible():
