Merge pull request #7530 from matthew-brett/tkagg-depends-on-tkinter

tacaswell · tacaswell · commit 7322046282ce · 2016-11-30T21:42:51.000-05:00
BLD: TkAgg default backend depends on tkinter
diff --git a/setup.py b/setup.py
@@ -194,9 +194,10 @@ def run(self):
                     required_failed.append(package)
             else:
                 good_packages.append(package)
-                if isinstance(package, setupext.OptionalBackendPackage):
-                    if default_backend is None:
-                        default_backend = package.name
+                if (isinstance(package, setupext.OptionalBackendPackage) and
+                        package.runtime_check() and
+                        default_backend is None):
+                    default_backend = package.name
     print_raw('')
 
     # Abort if any of the required packages can not be built.
diff --git a/setupext.py b/setupext.py
@@ -1,5 +1,7 @@
 from __future__ import print_function, absolute_import
 
+from importlib import import_module
+
 from distutils import sysconfig
 from distutils import version
 from distutils.core import Extension
@@ -402,13 +404,20 @@ class SetupPackage(object):
 
     def check(self):
         """
-        Checks whether the dependencies are met.  Should raise a
-        `CheckFailed` exception if the dependency could not be met,
-        otherwise return a string indicating a version number or some
-        other message indicating what was found.
+        Checks whether the build dependencies are met.  Should raise a
+        `CheckFailed` exception if the dependency could not be met, otherwise
+        return a string indicating a version number or some other message
+        indicating what was found.
         """
         pass
 
+    def runtime_check(self):
+        """
+        True if the runtime dependencies of the backend are met.  Assumes that
+        the build-time dependencies are met.
+        """
+        return True
+
     def get_packages(self):
         """
         Get a list of package names to add to the configuration.
@@ -1519,6 +1528,16 @@ class BackendTkAgg(OptionalBackendPackage):
     def check(self):
         return "installing; run-time loading from Python Tcl / Tk"
 
+    def runtime_check(self):
+        """ Checks whether TkAgg runtime dependencies are met
+        """
+        pkg_name = 'tkinter' if PY3min else 'Tkinter'
+        try:
+            import_module(pkg_name)
+        except ImportError:
+            return False
+        return True
+
     def get_extension(self):
         sources = [
             'src/py_converters.cpp',
