Do not decref FT2Font pointers

aitikgupta · tacaswell · commit 75caa485ecea · 2022-02-18T17:18:05.000-05:00
diff --git a/src/ft2font_wrapper.cpp b/src/ft2font_wrapper.cpp
@@ -664,7 +664,8 @@ static PyObject *PyFT2Font_fill_glyphs(PyFT2Font *self, PyObject *args, PyObject
                       || !(val = reinterpret_cast<PyObject *>(itr.second->get_pyfont()))
                       || (PyDict_SetItem(char_to_font, key, val) == -1));
         Py_XDECREF(key);
-        Py_XDECREF(val);
+        // do not decref value here, it's an FT2Font pointer
+
         if (error) {
             Py_DECREF(char_to_font);
             return NULL;
@@ -702,7 +703,8 @@ static PyObject *PyFT2Font_get_char_to_font(PyFT2Font *self, PyObject *args, PyO
                       || !(val = reinterpret_cast<PyObject *>(itr.second->get_pyfont()))
                       || (PyDict_SetItem(char_to_font, key, val) == -1));
         Py_XDECREF(key);
-        Py_XDECREF(val);
+        // do not decref value here, it's an FT2Font pointer
+
         if (error) {
             Py_DECREF(char_to_font);
             return NULL;
@@ -729,10 +731,9 @@ static PyObject *PyFT2Font_get_glyph_to_font(PyFT2Font *self, PyObject *args, Py
         bool error = (!(key = PyLong_FromLong(itr.first))
                       || !(val = reinterpret_cast<PyObject *>(itr.second->get_pyfont()))
                       || (PyDict_SetItem(glyph_to_font, key, val) == -1));
-        // Py_XDECREF(key);
-        // Py_XDECREF(val);
-        Py_INCREF(val);
-        Py_INCREF(key);
+        Py_XDECREF(key);
+        // do not decref value here, it's an FT2Font pointer
+
         if (error) {
             Py_DECREF(glyph_to_font);
             return NULL;
