Remove mlab.binary_repr

dstansby · dstansby · commit 76864f0f3f91 · 2018-09-29T11:05:10.000+01:00
diff --git a/doc/api/next_api_changes/2018-09-18-DS.rst b/doc/api/next_api_changes/2018-09-18-DS.rst
@@ -14,6 +14,7 @@ in Matplotlib 2.2 has been removed. See below for a list:
 - `mlab.frange` (use numpy.arange instead)
 - `mlab.identity` (use numpy.identity instead)
 - `mlab.base_repr`
+- `mlab.binary_repr`
 - `mlab.log2` (use numpy.log2 instead)
 - `mlab.cohere_pairs` (use scipy.signal.coherence instead)
 - `mlab.entropy` (use scipy.stats.entropy instead)
diff --git a/lib/matplotlib/mlab.py b/lib/matplotlib/mlab.py
@@ -1247,29 +1247,6 @@ def movavg(x, n):
 """
 
 
-@cbook.deprecated("2.2")
-def binary_repr(number, max_length=1025):
-    """
-    Return the binary representation of the input *number* as a
-    string.
-
-    This is more efficient than using :func:`base_repr` with base 2.
-
-    Increase the value of max_length for very large numbers. Note that
-    on 32-bit machines, 2**1023 is the largest integer power of 2
-    which can be converted to a Python float.
-    """
-
-#   assert number < 2L << max_length
-    shifts = map(operator.rshift, max_length * [number],
-                 range(max_length - 1, -1, -1))
-    digits = list(map(operator.mod, shifts, max_length * [2]))
-    if not digits.count(1):
-        return 0
-    digits = digits[digits.index(1):]
-    return ''.join(map(repr, digits)).replace('L', '')
-
-
 @cbook.deprecated("2.2")
 def ispower2(n):
     """
diff --git a/lib/matplotlib/pylab.py b/lib/matplotlib/pylab.py
@@ -229,7 +229,7 @@
 ## We are still importing too many things from mlab; more cleanup is needed.
 
 from matplotlib.mlab import (
-    binary_repr, csv2rec,
+    csv2rec,
     demean, detrend, detrend_linear, detrend_mean, detrend_none,
     ispower2, isvector,
     movavg,
