Remove nonworking ArtistInspector.findobj.

anntzer · anntzer · commit 7722070ec35a · 2016-12-03T14:38:39.000-08:00
diff --git a/doc/api/api_changes/code_removal.rst b/doc/api/api_changes/code_removal.rst
@@ -19,6 +19,9 @@ The ``GraphicsContextBase.set_graylevel``, ``FigureCanvasBase.onHilite`` and
 ``mpl_toolkits.axes_grid1.mpl_axes.Axes.toggle_axisline`` methods have been
 removed.
 
+The ``ArtistInspector.findobj`` method, which was never working due to the lack
+of a ``get_children`` method, has been removed.
+
 
 `Axes.set_aspect("normal")`
 ---------------------------
diff --git a/lib/matplotlib/artist.py b/lib/matplotlib/artist.py
@@ -1081,15 +1081,7 @@ def matchfunc(x):
             raise ValueError('match must be None, a matplotlib.artist.Artist '
                              'subclass, or a callable')
 
-        artists = []
-
-        for c in self.get_children():
-            if matchfunc(c):
-                artists.append(c)
-            artists.extend([thisc for thisc in
-                            c.findobj(matchfunc, include_self=False)
-                            if matchfunc(thisc)])
-
+        artists = sum([c.findobj(matchfunc) for c in self.get_children()], [])
         if include_self and matchfunc(self):
             artists.append(self)
         return artists
@@ -1409,45 +1401,6 @@ def pprint_getters(self):
             lines.append('    %s = %s' % (name, s))
         return lines
 
-    def findobj(self, match=None):
-        """
-        Recursively find all :class:`matplotlib.artist.Artist`
-        instances contained in *self*.
-
-        If *match* is not None, it can be
-
-          - function with signature ``boolean = match(artist)``
-
-          - class instance: e.g., :class:`~matplotlib.lines.Line2D`
-
-        used to filter matches.
-        """
-        if match is None:  # always return True
-            def matchfunc(x):
-                return True
-        elif issubclass(match, Artist):
-            def matchfunc(x):
-                return isinstance(x, match)
-        elif callable(match):
-            matchfunc = func
-        else:
-            raise ValueError('match must be None, a matplotlib.artist.Artist '
-                             'subclass, or a callable')
-
-        artists = []
-
-        for c in self.get_children():
-            if matchfunc(c):
-                artists.append(c)
-            artists.extend([thisc
-                            for thisc
-                            in c.findobj(matchfunc)
-                            if matchfunc(thisc)])
-
-        if matchfunc(self):
-            artists.append(self)
-        return artists
-
 
 def getp(obj, property=None):
     """
