Fix tkagg animation error at exit.

anntzer · anntzer · commit 77d9500dcec7 · 2017-12-02T22:41:51.000-08:00
Apparently, with a small enough animation interval, tk does not have the time to fully proceed through FigureManagerTkAgg.show before the animation takes over. Removing the call to self.window.update (which had been added back in 2004 (6c96389), but seems unnecessary (including on Windows)) fixes the issue. Also update the animation example so that it can serve as manual test for the issue; changed the rate at which the data moves to keep it reasonable, and switched to None (= count()) as index iterable to avoid a jump every time we reach the end of the indices.
diff --git a/examples/animation/simple_anim.py b/examples/animation/simple_anim.py
@@ -16,7 +16,7 @@
 
 
 def animate(i):
-    line.set_ydata(np.sin(x + i/10.0))  # update the data
+    line.set_ydata(np.sin(x + i / 100))  # update the data
     return line,
 
 
@@ -25,6 +25,6 @@ def init():
     line.set_ydata(np.ma.array(x, mask=True))
     return line,
 
-ani = animation.FuncAnimation(fig, animate, np.arange(1, 200), init_func=init,
-                              interval=25, blit=True)
+ani = animation.FuncAnimation(
+    fig, animate, init_func=init, interval=2, blit=True)
 plt.show()
diff --git a/lib/matplotlib/backends/backend_tkagg.py b/lib/matplotlib/backends/backend_tkagg.py
@@ -555,8 +555,6 @@ def destroy(*args):
                 Gcf.destroy(self._num)
             self.canvas._tkcanvas.bind("<Destroy>", destroy)
             self.window.deiconify()
-            # anim.py requires this
-            self.window.update()
         else:
             self.canvas.draw_idle()
         # Raise the new window.
