Removed our own MPL_isnan.h in favor of numpy's implementation

astraw · astraw · commit 7861461514f7 · 2007-07-13T18:24:23.000Z
svn path=/trunk/matplotlib/; revision=3512
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,6 @@
+2007-07-13 Removed our own MPL_isnan.h in favor of numpy's
+	   implementation -ADS
+
 2007-07-13 Added legend.loc as configurable option that could in
            future default to 'best'. - NN
 
diff --git a/setup.py b/setup.py
@@ -82,7 +82,7 @@
 from setupext import build_agg, build_gtkagg, build_tkagg, build_wxagg,\
      build_ft2font, build_image, build_windowing, build_transforms, \
      build_contour, build_nxutils, build_enthought, build_swigagg, build_gdk, \
-     build_subprocess, build_isnan, build_ttconv
+     build_subprocess, build_ttconv
 import distutils.sysconfig
 
 for line in file('lib/matplotlib/__init__.py').readlines():
@@ -156,8 +156,6 @@
     if sys.platform == 'win32':
         build_subprocess(ext_modules, packages)
 
-build_isnan(ext_modules, packages)
-
 try: import datetime
 except ImportError: havedate = False
 else: havedate = True
diff --git a/setupext.py b/setupext.py
@@ -943,11 +943,3 @@ def build_subprocess(ext_modules, packages):
         )
     add_base_flags(module)
     ext_modules.append(module)
-
-def build_isnan(ext_modules, packages):
-    module = Extension(
-        'matplotlib._isnan',
-        [ 'src/_isnan.c'],
-        )
-    add_base_flags(module)
-    ext_modules.append(module)
diff --git a/src/MPL_isnan.h b/src/MPL_isnan.h
diff --git a/src/_backend_agg.cpp b/src/_backend_agg.cpp
@@ -23,7 +23,6 @@
 #include "_backend_agg.h"
 #include "_transforms.h"
 #include "mplutils.h"
-#include "MPL_isnan.h"
 
 #include "swig_runtime.h"
 
@@ -35,6 +34,7 @@
 #else
 #define PY_ARRAY_TYPES_PREFIX NumPy
 #include "numpy/arrayobject.h"
+#include "numpy/ufuncobject.h"
 #endif
 #endif
 
@@ -1592,7 +1592,7 @@ RendererAgg::draw_lines(const Py::Tuple& args) {
         moveto = true;
         continue;
       }
-      if (MPL_isnan64(thisx) || MPL_isnan64(thisy)) {
+      if (isnan(thisx) || isnan(thisy)) {
         moveto = true;
         continue;
       }
diff --git a/src/_isnan.c b/src/_isnan.c
diff --git a/src/_transforms.cpp b/src/_transforms.cpp
@@ -4,16 +4,13 @@
 
 #include "_transforms.h"
 #include "mplutils.h"
-#include "MPL_isnan.h"
 
 
 #include "numpy/arrayobject.h"
-//#include "numpy/ufuncobject.h"
-
-
-//bool skip_float(double x) {
-//  return !MPL_isnan64(x) && !isinf(x);
-//}
+#include "numpy/ufuncobject.h"
+#if !defined(isfinite)
+#define isfinite(x) (!(isinf((x)) || isnan((x))))
+#endif
 
 Value::~Value() {
   _VERBOSE("Value::~Value");
@@ -471,31 +468,23 @@ Bbox::update(const Py::Tuple &args) {
 
   Py::Tuple tup;
   if (ignore) {
-    tup = xys[0];
-    double x = Py::Float(tup[0]);
-    double y = Py::Float(tup[1]);
-
-    minx=x;
-    maxx=x;
-    miny=y;
-    maxy=y;
+    minx = miny = std::numeric_limits<double>::max();
+    maxx = maxy = std::numeric_limits<double>::min();
   }
 
-
   for (size_t i=0; i<Nx; ++i) {
     tup = xys[i];
     double x = Py::Float(tup[0]);
     double y = Py::Float(tup[1]);
+    if (isnan(x) || isnan(y)) continue;
     _posx.update(x);
     _posy.update(y);
     if (x<minx) minx=x;
     if (x>maxx) maxx=x;
     if (y<miny) miny=y;
     if (y>maxy) maxy=y;
-
   }
 
-
   _ll->x_api()->set_api(minx);
   _ll->y_api()->set_api(miny);
   _ur->x_api()->set_api(maxx);
@@ -551,7 +540,7 @@ Bbox::update_numerix_xy(const Py::Tuple &args) {
   for (size_t i=0; i< Nxy; ++i) {
     thisx = *(double *)(xyin->data + i*xyin->strides[0]);
     thisy = *(double *)(xyin->data + i*xyin->strides[0] + xyin->strides[1]);
-    if (MPL_isnan64(thisx) || MPL_isnan64(thisy)) continue;
+    if (isnan(thisx) || isnan(thisy)) continue;
     _posx.update(thisx);
     _posy.update(thisy);
     if (thisx<minx) minx=thisx;
@@ -618,37 +607,14 @@ Bbox::update_numerix(const Py::Tuple &args) {
     _ignore = 0; // don't ignore future updates
   }
   if (ignore) {
-    int xok=0;
-    int yok=0;
-    // loop through values until we find some nans...
-    for (size_t i=0; i< Nx; ++i) {
-      thisx = *(double *)(x->data + i*x->strides[0]);
-      thisy = *(double *)(y->data + i*y->strides[0]);
-
-      if (!xok) {
-	if (!MPL_isnan64(thisx)) {
-	  minx=thisx;
-	  maxx=thisx;
-	  xok=1;
-	}
-      }
-
-      if (!yok) {
-	if (!MPL_isnan64(thisy)) {
-	  miny=thisy;
-	  maxy=thisy;
-	  yok=1;
-	}
-      }
-
-      if (xok && yok) break;
-    }
+    minx = miny = std::numeric_limits<double>::max();
+    maxx = maxy = std::numeric_limits<double>::min();
   }
 
   for (size_t i=0; i< Nx; ++i) {
     thisx = *(double *)(x->data + i*x->strides[0]);
     thisy = *(double *)(y->data + i*y->strides[0]);
-
+    if (isnan(thisx) || isnan(thisy)) continue;
     _posx.update(thisx);
     _posy.update(thisy);
     if (thisx<minx) minx=thisx;
@@ -1290,18 +1256,18 @@ Transformation::nonlinear_only_numerix(const Py::Tuple & args, const Py::Dict &k
 
     double thisx = *(double *)(x->data + i*x->strides[0]);
     double thisy = *(double *)(y->data + i*y->strides[0]);
-    if (MPL_isnan64(thisx) || MPL_isnan64(thisy)) {
+    if (isnan(thisx) || isnan(thisy)) {
       if (returnMask) {
 	*(unsigned char *)(retmask->data + i*retmask->strides[0]) = 0;
       }
-      double MPLnan; // don't require C99 math features - find our own nan
-      if (MPL_isnan64(thisx)) {
-	MPLnan=thisx;
+      double MPL_not_finite; // don't require C99 math features - find our own nan
+      if (isnan(thisx)) {
+	MPL_not_finite=thisx;
       } else {
-	MPLnan=thisy;
+	MPL_not_finite=thisy;
       }
-      *(double *)(retx->data + i*retx->strides[0]) = MPLnan;
-      *(double *)(rety->data + i*rety->strides[0]) = MPLnan;
+      *(double *)(retx->data + i*retx->strides[0]) = MPL_not_finite;
+      *(double *)(rety->data + i*rety->strides[0]) = MPL_not_finite;
     } else {
       try {
 	this->nonlinear_only_api(&thisx, &thisy);
