Fix test, and make minor ticks work again

efiring · efiring · commit 7c9acc03571e · 2016-09-09T17:07:49.000-10:00
diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py
@@ -94,11 +94,11 @@ def test_LogLocator_set_params():
     Should not exception.
     """
     loc = mticker.LogLocator()
-    loc.set_params(numticks=8, numdecs=8, subs=[2.0], base=8)
-    nose.tools.assert_equal(loc.numticks, 8)
+    loc.set_params(numticks=7, numdecs=8, subs=[2.0], base=4)
+    nose.tools.assert_equal(loc.numticks, 7)
     nose.tools.assert_equal(loc.numdecs, 8)
-    nose.tools.assert_equal(loc.base, 8)
-    nose.tools.assert_equal(loc.subs, [2.0])
+    nose.tools.assert_equal(loc._base, 4)
+    nose.tools.assert_equal(list(loc._subs), [2.0])
 
 
 def test_NullLocator_set_params():
diff --git a/lib/matplotlib/ticker.py b/lib/matplotlib/ticker.py
@@ -1757,13 +1757,11 @@ class LogLocator(Locator):
     Determine the tick locations for log axes
     """
 
-    def __init__(self, base=10.0, subs=None, numdecs=4, numticks=15):
+    def __init__(self, base=10.0, subs=(1.0,), numdecs=4, numticks=15):
         """
         place ticks on the location= base**i*subs[j]
         """
         self.base(base)
-        if subs is None:
-            subs = [1.0]
         self.subs(subs)
         # this needs to be validated > 1 with traitlets
         self.numticks = numticks
