TST: Cleanup new tests a bit.

QuLogic · QuLogic · commit 7cf0e22680a2 · 2018-01-06T05:25:53.000-05:00
Matplotlib doesn't support pytest Path objects, so convert to str.
Remove unnecessary randomness and fix typos.
diff --git a/lib/matplotlib/tests/test_backend_pdf.py b/lib/matplotlib/tests/test_backend_pdf.py
@@ -220,13 +220,14 @@ def test_pdf_savefig_when_color_is_none(tmpdir):
     assert result is None
 
 
+@needs_usetex
 def test_failing_latex(tmpdir):
     """Test failing latex subprocess call"""
-    path = tmpdir.join("tmpoutput.pdf")
+    path = str(tmpdir.join("tmpoutput.pdf"))
 
     rcParams['text.usetex'] = True
 
-    # This failes with "Double subscript"
-    plt.xlabel("$%f_2_2$" % np.random.random())
-    with pytest.raises(RuntimeError) as excinfo:
+    # This fails with "Double subscript"
+    plt.xlabel("$22_2_2$")
+    with pytest.raises(RuntimeError):
         plt.savefig(path)
diff --git a/lib/matplotlib/tests/test_backend_ps.py b/lib/matplotlib/tests/test_backend_ps.py
@@ -11,7 +11,7 @@
 
 import matplotlib
 import matplotlib.pyplot as plt
-from matplotlib import patheffects, rcParams
+from matplotlib import patheffects
 from matplotlib.testing.decorators import image_comparison
 from matplotlib.testing.determinism import (_determinism_source_date_epoch,
                                             _determinism_check)
@@ -162,11 +162,11 @@ def test_transparency():
 @needs_usetex
 def test_failing_latex(tmpdir):
     """Test failing latex subprocess call"""
-    path = tmpdir.join("tmpoutput.ps")
+    path = str(tmpdir.join("tmpoutput.ps"))
 
-    rcParams['text.usetex'] = True
+    matplotlib.rcParams['text.usetex'] = True
 
-    # This failes with "Double subscript"
-    plt.xlabel("$%f_2_2$" % np.random.random())
-    with pytest.raises(RuntimeError) as excinfo:
+    # This fails with "Double subscript"
+    plt.xlabel("$22_2_2$")
+    with pytest.raises(RuntimeError):
         plt.savefig(path)
