MAINT: Pre-compute the cuboid array

eric-wieser · eric-wieser · commit 7d09535d2981 · 2018-09-16T17:16:24.000-07:00
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -2432,54 +2432,57 @@ def bar3d(self, x, y, z, dx, dy, dz, color=None,
         minz = np.min(z)
         maxz = np.max(z + dz)
 
+        # shape (6, 4, 3)
+        cuboid = np.array([
+            # -z
+            (
+                (0, 0, 0),
+                (1, 0, 0),
+                (1, 1, 0),
+                (0, 1, 0)
+            ),
+            # +z
+            (
+                (0, 0, 1),
+                (1, 0, 1),
+                (1, 1, 1),
+                (0, 1, 1)
+            ),
+            # -y
+            (
+                (0, 0, 0),
+                (1, 0, 0),
+                (1, 0, 1),
+                (0, 0, 1)
+            ),
+            # +y
+            (
+                (0, 1, 0),
+                (1, 1, 0),
+                (1, 1, 1),
+                (0, 1, 1)
+            ),
+            # -x
+            (
+                (0, 0, 0),
+                (0, 1, 0),
+                (0, 1, 1),
+                (0, 0, 1)
+            ),
+            # +x
+            (
+                (1, 0, 0),
+                (1, 1, 0),
+                (1, 1, 1),
+                (1, 0, 1)
+            ),
+        ])
+
         polys = []
         for xi, yi, zi, dxi, dyi, dzi in zip(x, y, z, dx, dy, dz):
             corner = np.array([xi, yi, zi])
             scale = np.array([dxi, dyi, dzi])
-            polys.extend(corner + scale * [
-                # -z
-                (
-                    (0, 0, 0),
-                    (1, 0, 0),
-                    (1, 1, 0),
-                    (0, 1, 0)
-                ),
-                # +z
-                (
-                    (0, 0, 1),
-                    (1, 0, 1),
-                    (1, 1, 1),
-                    (0, 1, 1)
-                ),
-                # -y
-                (
-                    (0, 0, 0),
-                    (1, 0, 0),
-                    (1, 0, 1),
-                    (0, 0, 1)
-                ),
-                # +y
-                (
-                    (0, 1, 0),
-                    (1, 1, 0),
-                    (1, 1, 1),
-                    (0, 1, 1)
-                ),
-                # -x
-                (
-                    (0, 0, 0),
-                    (0, 1, 0),
-                    (0, 1, 1),
-                    (0, 0, 1)
-                ),
-                # +x
-                (
-                    (1, 0, 0),
-                    (1, 1, 0),
-                    (1, 1, 1),
-                    (1, 0, 1)
-                ),
-            ])
+            polys.extend(corner + scale * cuboid)
 
         facecolors = []
         if color is None:
