Set colorbar label only in set_label.

anntzer · anntzer · commit 7dc926e26518 · 2020-07-01T19:31:49.000+02:00
... instead of doing so also in _config_axis.

_config_axis is also called when e.g. the norm is changed, but we don't
want to reset the label in that case.

Note that the previous `self._labelkw` was only usable for one colorbar
orientation anyways (because the choice of `_pos_kw` depends on the
orientation) so everything was already tied to a single orientation.
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -548,7 +548,7 @@ def _config_axis(self):
                       ticks_position=self.ticklocation)
         short_axis.set_ticks([])
         short_axis.set_ticks([], minor=True)
-        self._set_label()
+        self.stale = True
 
     def _get_ticker_locator_formatter(self):
         """
@@ -726,16 +726,8 @@ def minorticks_off(self):
         """Turn the minor ticks of the colorbar off."""
         ax = self.ax
         long_axis = ax.yaxis if self.orientation == 'vertical' else ax.xaxis
-
         long_axis.set_minor_locator(ticker.NullLocator())
 
-    def _set_label(self):
-        if self.orientation == 'vertical':
-            self.ax.set_ylabel(self._label, **self._labelkw)
-        else:
-            self.ax.set_xlabel(self._label, **self._labelkw)
-        self.stale = True
-
     def set_label(self, label, *, loc=None, **kwargs):
         """Add a label to the long axis of the colorbar."""
         _pos_xy = 'y' if self.orientation == 'vertical' else 'x'
@@ -759,9 +751,11 @@ def set_label(self, label, *, loc=None, **kwargs):
         elif loc in ['left', 'bottom']:
             kwargs[_pos_xy] = 0.
             kwargs['horizontalalignment'] = 'left'
-        self._label = label
-        self._labelkw = kwargs
-        self._set_label()
+        if self.orientation == 'vertical':
+            self.ax.set_ylabel(label, **kwargs)
+        else:
+            self.ax.set_xlabel(label, **kwargs)
+        self.stale = True
 
     def _outline(self, X, Y):
         """
