FIX: don't compute flier positions if not showing

phobson · QuLogic · commit 7e44d70859e2 · 2016-10-15T22:59:23.000-04:00
Closes GH #7263 Fliers are documented as being optional when showfliers=False. However the Axes.bxp method was trying to compute the x-values of the flier artists based on the length of the flier array before the logic to draw them.
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -3723,9 +3723,6 @@ def dopatch(xs, ys, **kwargs):
         for pos, width, stats in zip(positions, widths, bxpstats):
             # try to find a new label
             datalabels.append(stats.get('label', pos))
-            # fliers coords
-            flier_x = np.ones(len(stats['fliers'])) * pos
-            flier_y = stats['fliers']
 
             # whisker coords
             whisker_x = np.ones(2) * pos
@@ -3799,6 +3796,10 @@ def dopatch(xs, ys, **kwargs):
 
             # maybe draw the fliers
             if showfliers:
+                # fliers coords
+                flier_x = np.ones(len(stats['fliers'])) * pos
+                flier_y = stats['fliers']
+
                 fliers.extend(doplot(
                     flier_x, flier_y, **final_flierprops
                 ))
diff --git a/lib/matplotlib/tests/baseline_images/test_axes/bxp_no_flier_stats.png b/lib/matplotlib/tests/baseline_images/test_axes/bxp_no_flier_stats.png
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -1713,6 +1713,23 @@ def test_bxp_nobox():
     ax.bxp(logstats, showbox=False)
 
 
+@image_comparison(baseline_images=['bxp_no_flier_stats'],
+                  remove_text=True, extensions=['png'],
+                  savefig_kwarg={'dpi': 40},
+                  style='default')
+def test_bxp_no_flier_stats():
+    np.random.seed(937)
+    logstats = matplotlib.cbook.boxplot_stats(
+        np.random.lognormal(mean=1.25, sigma=1., size=(37, 4))
+    )
+    for ls in logstats:
+        ls.pop('fliers', None)
+
+    fig, ax = plt.subplots()
+    ax.set_yscale('log')
+    ax.bxp(logstats, showfliers=False)
+
+
 @image_comparison(baseline_images=['bxp_withmean_point'],
                   remove_text=True, extensions=['png'],
                   savefig_kwarg={'dpi': 40},
