TST: fix skip logic and make test symmetric

tacaswell · timhoffm · web-flow · commit 8059fe9aac40 · 2021-02-15T20:35:19.000-05:00
Co-authored-by: Tim Hoffmann &lt;2836374+timhoffm@users.noreply.github.com&gt;
diff --git a/lib/matplotlib/tests/test_usetex.py b/lib/matplotlib/tests/test_usetex.py
@@ -81,21 +81,21 @@ def test_minus_no_descent(fontsize):
     assert len({*heights.values()}) == 1
 
 
-@pytest.mark.skipif(_has_tex_package('xcolor.sty'),
+@pytest.mark.skipif(not _has_tex_package('xcolor.sty'),
                     reason='xcolor is not available')
 def test_usetex_xcolor():
     mpl.rcParams['text.usetex'] = True
 
     fig = plt.figure()
-    t = fig.text(0.5, 0.5, "Some text 0123456789")
+    text = fig.text(0.5, 0.5, "Some text 0123456789")
     fig.canvas.draw()
-    pos = t.get_window_extent()
 
     mpl.rcParams['text.latex.preamble'] = r'\usepackage[dvipsnames]{xcolor}'
     fig = plt.figure()
-    t = fig.text(0.5, 0.5, "Some text 0123456789")
+    text2 = fig.text(0.5, 0.5, "Some text 0123456789")
     fig.canvas.draw()
-    np.testing.assert_array_equal(t.get_window_extent(), pos)
+    np.testing.assert_array_equal(text2.get_window_extent(),
+                                  text.get_window_extent())
 
 
 def test_textcomp_full():
