Merge pull request #9855 from jklymak/enh-update-aspect

phobson · web-flow · commit 83507dcdfdd7 · 2018-04-10T12:23:43.000-07:00
ENH: make ax.get_position apply aspect
diff --git a/doc/api/api_changes/2017-11-25-JMK.rst b/doc/api/api_changes/2017-11-25-JMK.rst
@@ -0,0 +1,8 @@
+`.Axes.get_position` now returns actual position if aspect changed
+------------------------------------------------------------------
+
+`.Axes.get_position` used to return the original position unless a
+draw had been triggered or `.Axes.apply_aspect` had been called, even
+if the kwarg *original* was set to *False*.   Now `.Axes.apply_aspect`
+is called so ``ax.get_position()`` will return the new modified position.
+To get the old behaviour, ``ax.get_position(original=True)``.  
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -848,6 +848,7 @@ def get_position(self, original=False):
         if original:
             return self._originalPosition.frozen()
         else:
+            self.apply_aspect()
             return self._position.frozen()
 
     def set_position(self, pos, which='both'):
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -1286,7 +1286,7 @@ def make_axes(parents, location=None, orientation=None, fraction=0.15,
 
     # transform each of the axes in parents using the new transform
     for ax in parents:
-        new_posn = shrinking_trans.transform(ax.get_position())
+        new_posn = shrinking_trans.transform(ax.get_position(original=True))
         new_posn = mtransforms.Bbox(new_posn)
         ax._set_position(new_posn)
         if parent_anchor is not False:
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -22,7 +22,8 @@
 import matplotlib.markers as mmarkers
 import matplotlib.patches as mpatches
 import matplotlib.colors as mcolors
-from numpy.testing import assert_allclose, assert_array_equal
+from numpy.testing import (
+    assert_allclose, assert_array_equal, assert_array_almost_equal)
 from matplotlib.cbook import (
     IgnoredKeywordWarning, MatplotlibDeprecationWarning)
 
@@ -4940,6 +4941,12 @@ def test_square_plot():
     xlim, ylim = ax.get_xlim(), ax.get_ylim()
     assert np.diff(xlim) == np.diff(ylim)
     assert ax.get_aspect() == 'equal'
+    assert_array_almost_equal(
+            ax.get_position(original=True).extents,
+            np.array((0.125, 0.1, 0.9, 0.9)))
+    assert_array_almost_equal(
+        ax.get_position(original=False).extents,
+        np.array((0.2125, 0.1, 0.8125, 0.9)))
 
 
 def test_no_None():
