fix error to raise, improved testing

fariza · fariza · commit 848ed7a2c171 · 2018-02-07T14:08:40.000-05:00
diff --git a/lib/matplotlib/table.py b/lib/matplotlib/table.py
@@ -301,7 +301,7 @@ def __setitem__(self, position, cell):
         Set a customcell in a given position
         """
         if not isinstance(cell, CustomCell):
-            raise ValueError('Table only accepts CustomCell')
+            raise TypeError('Table only accepts CustomCell')
         try:
             row, col = position[0], position[1]
         except Exception:
diff --git a/lib/matplotlib/tests/test_table.py b/lib/matplotlib/tests/test_table.py
@@ -184,11 +184,13 @@ def test_auto_column():
 
 
 def test_table_cells():
-    fig = plt.figure()
-    ax = fig.add_subplot(1, 1, 1)
+    fig, ax = plt.subplots()
     table = Table(ax)
 
     cell = table.add_cell(1, 2, 1, 1)
     assert isinstance(cell, CustomCell)
-    table[2, 1] = cell
-    assert table[2, 1] is cell
+    assert cell is table[1, 2]
+
+    cell2 = CustomCell((0, 0), 1, 2, visible_edges=None)
+    table[2, 1] = cell2
+    assert table[2, 1] is cell2
