Make all arguments to Collection and most to subclasses keyword only

oscargus · oscargus · commit 879a3ce54acb · 2023-01-16T10:50:42.000+01:00
diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
@@ -74,8 +74,7 @@ class Collection(artist.Artist, cm.ScalarMappable):
     _edge_default = False
 
     @_docstring.interpd
-    @_api.make_keyword_only("3.6", name="edgecolors")
-    def __init__(self,
+    def __init__(self, *,
                  edgecolors=None,
                  facecolors=None,
                  linewidths=None,
@@ -90,7 +89,6 @@ def __init__(self,
                  pickradius=5.0,
                  hatch=None,
                  urls=None,
-                 *,
                  zorder=1,
                  **kwargs
                  ):
@@ -1148,8 +1146,7 @@ def legend_elements(self, prop="colors", num="auto",
 
 class PolyCollection(_CollectionWithSizes):
 
-    @_api.make_keyword_only("3.6", name="closed")
-    def __init__(self, verts, sizes=None, closed=True, **kwargs):
+    def __init__(self, verts, sizes=None, *, closed=True, **kwargs):
         """
         Parameters
         ----------
@@ -1279,9 +1276,9 @@ class RegularPolyCollection(_CollectionWithSizes):
     _path_generator = mpath.Path.unit_regular_polygon
     _factor = np.pi ** (-1/2)
 
-    @_api.make_keyword_only("3.6", name="rotation")
     def __init__(self,
                  numsides,
+                 *,
                  rotation=0,
                  sizes=(1,),
                  **kwargs):
@@ -1492,10 +1489,10 @@ class EventCollection(LineCollection):
 
     _edge_default = True
 
-    @_api.make_keyword_only("3.6", name="lineoffset")
     def __init__(self,
                  positions,  # Cannot be None.
                  orientation='horizontal',
+                 *,
                  lineoffset=0,
                  linelength=1,
                  linewidth=None,
@@ -1688,8 +1685,7 @@ def __init__(self, sizes, **kwargs):
 class EllipseCollection(Collection):
     """A collection of ellipses, drawn using splines."""
 
-    @_api.make_keyword_only("3.6", name="units")
-    def __init__(self, widths, heights, angles, units='points', **kwargs):
+    def __init__(self, widths, heights, angles, *, units='points', **kwargs):
         """
         Parameters
         ----------
@@ -1776,8 +1772,7 @@ class PatchCollection(Collection):
     collection of patches.
     """
 
-    @_api.make_keyword_only("3.6", name="match_original")
-    def __init__(self, patches, match_original=False, **kwargs):
+    def __init__(self, patches, *, match_original=False, **kwargs):
         """
         Parameters
         ----------
