Merge pull request #17517 from astrofrog/fix-parent-set

tacaswell · web-flow · commit 880ade0b77dc · 2020-05-28T09:39:44.000-04:00
MNT: Fully remove _parent NavigationToolbar2QT
diff --git a/lib/matplotlib/backends/backend_qt5.py b/lib/matplotlib/backends/backend_qt5.py
@@ -656,7 +656,6 @@ def __init__(self, canvas, parent, coordinates=True):
         self.setAllowedAreas(
             QtCore.Qt.TopToolBarArea | QtCore.Qt.BottomToolBarArea)
 
-        self._parent = parent
         self.coordinates = coordinates
         self._actions = {}  # mapping of toolitem method names to QActions.
 
@@ -687,8 +686,15 @@ def __init__(self, canvas, parent, coordinates=True):
 
         NavigationToolbar2.__init__(self, canvas)
 
-    parent = cbook._deprecate_privatize_attribute(
-        "3.3", alternative="self.canvas.parent()")
+    @cbook.deprecated("3.3", alternative="self.canvas.parent()")
+    @property
+    def parent(self):
+        return self.canvas.parent()
+
+    @cbook.deprecated("3.3", alternative="self.canvas.setParent()")
+    @parent.setter
+    def parent(self, value):
+        pass
 
     @cbook.deprecated(
         "3.3", alternative="os.path.join(mpl.get_data_path(), 'images')")
