Library code should never call update_idletasks

richardsheridan · richardsheridan · commit 8a8786fe7a72 · 2020-08-08T15:36:32.000-04:00
diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
@@ -209,7 +209,6 @@ def __init__(self, figure, master=None, resize_callback=None):
         # to the window and filter.
         def filter_destroy(event):
             if event.widget is self._tkcanvas:
-                self._master.update_idletasks()
                 self.close_event()
         root.bind("<Destroy>", filter_destroy, "+")
 
@@ -554,8 +553,6 @@ def set_cursor(self, cursor):
             window.configure(cursor=cursord[cursor])
         except tkinter.TclError:
             pass
-        else:
-            window.update_idletasks()
 
     def _Button(self, text, image_file, toggle, command):
         image = (tk.PhotoImage(master=self, file=image_file)
diff --git a/lib/matplotlib/backends/backend_tkagg.py b/lib/matplotlib/backends/backend_tkagg.py
@@ -8,12 +8,10 @@ class FigureCanvasTkAgg(FigureCanvasAgg, FigureCanvasTk):
     def draw(self):
         super().draw()
         _backend_tk.blit(self._tkphoto, self.renderer._renderer, (0, 1, 2, 3))
-        self._master.update_idletasks()
 
     def blit(self, bbox=None):
         _backend_tk.blit(
             self._tkphoto, self.renderer._renderer, (0, 1, 2, 3), bbox=bbox)
-        self._master.update_idletasks()
 
 
 @_BackendTk.export
diff --git a/lib/matplotlib/backends/backend_tkcairo.py b/lib/matplotlib/backends/backend_tkcairo.py
@@ -23,7 +23,6 @@ def draw(self):
         _backend_tk.blit(
             self._tkphoto, buf,
             (2, 1, 0, 3) if sys.byteorder == "little" else (1, 2, 3, 0))
-        self._master.update_idletasks()
 
 
 @_BackendTk.export
