Only make the unguarded API warning an error

dopplershift · dopplershift · commit 8ad6a3df294a · 2020-07-18T16:29:16.000-06:00
We have other deprecated constants that flags warnings in CI.
Unfortunately, the deprecations occur in the same version when the new
names are introduced, and we can't rely on those being available yet.
diff --git a/setupext.py b/setupext.py
@@ -657,7 +657,7 @@ def get_extensions(self):
             'src/_macosx.m'
             ]
         ext = Extension('matplotlib.backends._macosx', sources)
-        ext.extra_compile_args.extend(['-Wunguarded-availability', '-Werror'])
+        ext.extra_compile_args.extend(['-Werror=unguarded-availability'])
         ext.extra_link_args.extend(['-framework', 'Cocoa'])
         if platform.python_implementation().lower() == 'pypy':
             ext.extra_compile_args.append('-DPYPY=1')

Original file line number	Diff line number	Diff line change
`@@ -657,7 +657,7 @@ def get_extensions(self):`
`657`	`657`	`'src/_macosx.m'`
`658`	`658`	`]`
`659`	`659`	`ext = Extension('matplotlib.backends._macosx', sources)`
`660`		`- ext.extra_compile_args.extend(['-Wunguarded-availability', '-Werror'])`
	`660`	`+ ext.extra_compile_args.extend(['-Werror=unguarded-availability'])`
`661`	`661`	`ext.extra_link_args.extend(['-framework', 'Cocoa'])`
`662`	`662`	`if platform.python_implementation().lower() == 'pypy':`
`663`	`663`	`ext.extra_compile_args.append('-DPYPY=1')`