Merge pull request #13333 from QuLogic/PySequence_GetItem-leak

NelleV · web-flow · commit 8d627698ab51 · 2019-02-01T23:14:41.000-08:00
Fix possible leak of return of PySequence_GetItem.
diff --git a/src/_path_wrapper.cpp b/src/_path_wrapper.cpp
@@ -725,6 +725,7 @@ static PyObject *Py_convert_to_string(PyObject *self, PyObject *args, PyObject *
             return NULL;
         }
         codes[i] = PyBytes_AsString(item);
+        Py_DECREF(item);
         if (codes[i] == NULL) {
             return NULL;
         }
diff --git a/src/py_adaptors.h b/src/py_adaptors.h
@@ -240,6 +240,7 @@ class PathGenerator
             throw py::exception();
         }
         if (!convert_path(item, &path)) {
+            Py_DECREF(item);
             throw py::exception();
         }
         Py_DECREF(item);

Original file line number	Diff line number	Diff line change
`@@ -725,6 +725,7 @@ static PyObject Py_convert_to_string(PyObject self, PyObject args, PyObject `
`725`	`725`	`return NULL;`
`726`	`726`	`}`
`727`	`727`	`codes[i] = PyBytes_AsString(item);`
	`728`	`+ Py_DECREF(item);`
`728`	`729`	`if (codes[i] == NULL) {`
`729`	`730`	`return NULL;`
`730`	`731`	`}`