Merge pull request #17369 from QuLogic/reviewdog-eslint

tacaswell · web-flow · commit 8f3f6897b116 · 2020-05-08T19:47:21.000-04:00
CI: Add eslint for JS linting
diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml
@@ -18,11 +18,28 @@ jobs:
 
       - name: Set up reviewdog
         run: |
-          mkdir -p $HOME/bin && curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b $HOME/bin
+          mkdir -p $HOME/bin
+          curl -sfL \
+            https://github.com/reviewdog/reviewdog/raw/master/install.sh | \
+              sh -s -- -b $HOME/bin
           echo ::add-path::$HOME/bin
 
       - name: Run flake8
         env:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          flake8 --docstring-convention=all | reviewdog -f=pep8 -name=flake8 -reporter=github-check
+          flake8 --docstring-convention=all | \
+            reviewdog -f=pep8 -name=flake8 -reporter=github-check
+
+  eslint:
+    name: eslint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: eslint
+        uses: reviewdog/action-eslint@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-check
+          workdir: 'lib/matplotlib/backends/web_backend/'
diff --git a/lib/matplotlib/backends/web_backend/.eslintrc.js b/lib/matplotlib/backends/web_backend/.eslintrc.js
@@ -11,11 +11,22 @@ module.exports = {
     MozWebSocket: "readonly",
   },
   rules: {
+    indent: ["error", 2, { SwitchCase: 1 }],
     "no-unused-vars": [
       "error",
       {
         argsIgnorePattern: "^_",
       },
     ],
+    quotes: ["error", "double", { avoidEscape: true }],
   },
+  overrides: [
+    {
+      files: "js/**/*.js",
+      rules: {
+        indent: ["error", 4, { SwitchCase: 1 }],
+        quotes: ["error", "single", { avoidEscape: true }],
+      },
+    },
+  ],
 };
