TST: add a check that the hinting factor is greater than 0

tacaswell · tacaswell · commit 8f64165c90d8 · 2022-07-07T17:06:13.000-04:00
If you pass 0 it will cause a divide by 0 error and kill Python.
diff --git a/lib/matplotlib/tests/test_font_manager.py b/lib/matplotlib/tests/test_font_manager.py
@@ -360,3 +360,11 @@ def test_fallback_errors():
             TypeError, match="Fallback fonts must be FT2Font objects."
     ):
         ft2font.FT2Font(file_name, _fallback_list=[0])
+
+
+def test_ft2font_positive_hinting_factor():
+    file_name = findfont('DejaVu Sans')
+    with pytest.raises(
+            ValueError, match="hinting_factor must be greater than 0"
+    ):
+        ft2font.FT2Font(file_name, 0)
diff --git a/src/ft2font_wrapper.cpp b/src/ft2font_wrapper.cpp
@@ -362,6 +362,11 @@ static int PyFT2Font_init(PyFT2Font *self, PyObject *args, PyObject *kwds)
              &hinting_factor, &fallback_list, &kerning_factor)) {
         return -1;
     }
+    if (hinting_factor <= 0) {
+      PyErr_SetString(PyExc_ValueError,
+                      "hinting_factor must be greater than 0");
+      goto exit;
+    }
 
     self->stream.base = NULL;
     self->stream.size = 0x7fffffff;  // Unknown size.
