Refactored repeated code in _set_caretxxx functions

sindunuragarp · sindunuragarp · commit 8f86eb628468 · 2017-03-13T20:49:48.000+01:00
diff --git a/determinism_tex.svg b/determinism_tex.svg
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="utf-8" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
+  "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<!-- Created with matplotlib (http://matplotlib.org/) -->
+<svg height="345pt" version="1.1" viewBox="0 0 460 345" width="460pt" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <defs>
+  <style type="text/css">
+*{stroke-linecap:butt;stroke-linejoin:round;}
+  </style>
+ </defs>
+ <g id="figure_1">
+  <g id="patch_1">
+   <path d="M 0 345.6 
+L 460.8 345.6 
+L 460.8 0 
+L 0 0 
+z
+" style="fill:#ffffff;"/>
+  </g>
+  <g id="axes_1">
+   <g id="patch_2">
+    <path d="M 57.6 307.584 
+L 414.72 307.584 
+L 414.72 41.472 
+L 57.6 41.472 
+z
+" style="fill:#ffffff;"/>
+   </g>
+   <g id="matplotlib.axis_1"
diff --git a/lib/matplotlib/markers.py b/lib/matplotlib/markers.py
@@ -760,55 +760,34 @@ def _set_caretdown(self):
         self._joinstyle = 'miter'
 
     def _set_caretup(self):
-        self._transform = Affine2D().scale(0.5).rotate_deg(180)
-        self._snap_threshold = 3.0
-        self._filled = False
-        self._path = self._caret_path
-        self._joinstyle = 'miter'
+        self._set_caretdown()
+        self._transform = self._transform.rotate_deg(180)
 
     def _set_caretleft(self):
-        self._transform = Affine2D().scale(0.5).rotate_deg(270)
-        self._snap_threshold = 3.0
-        self._filled = False
-        self._path = self._caret_path
-        self._joinstyle = 'miter'
+        self._set_caretdown()
+        self._transform = self._transform.rotate_deg(270)
 
     def _set_caretright(self):
-        self._transform = Affine2D().scale(0.5).rotate_deg(90)
-        self._snap_threshold = 3.0
-        self._filled = False
-        self._path = self._caret_path
-        self._joinstyle = 'miter'
+        self._set_caretdown()
+        self._transform = self._transform.rotate_deg(90)
 
     _caret_path_base = Path([[-1.0, 0.0], [0.0, -1.5], [1.0, 0]])
 
     def _set_caretdownbase(self):
-        self._transform = Affine2D().scale(0.5)
-        self._snap_threshold = 3.0
-        self._filled = False
+        self._set_caretdown()
         self._path = self._caret_path_base
-        self._joinstyle = 'miter'
 
     def _set_caretupbase(self):
-        self._transform = Affine2D().scale(0.5).rotate_deg(180)
-        self._snap_threshold = 3.0
-        self._filled = False
-        self._path = self._caret_path_base
-        self._joinstyle = 'miter'
+        self._set_caretdownbase()
+        self._transform = self._transform.rotate_deg(180)
 
     def _set_caretleftbase(self):
-        self._transform = Affine2D().scale(0.5).rotate_deg(270)
-        self._snap_threshold = 3.0
-        self._filled = False
-        self._path = self._caret_path_base
-        self._joinstyle = 'miter'
+        self._set_caretdownbase()
+        self._transform = self._transform.rotate_deg(270)
 
     def _set_caretrightbase(self):
-        self._transform = Affine2D().scale(0.5).rotate_deg(90)
-        self._snap_threshold = 3.0
-        self._filled = False
-        self._path = self._caret_path_base
-        self._joinstyle = 'miter'
+        self._set_caretdownbase()
+        self._transform = self._transform.rotate_deg(90)
 
     _plus_path = Path([[-1.0, 0.0], [1.0, 0.0],
                        [0.0, -1.0], [0.0, 1.0]],
