Deprecate FigureCanvasBase.switch_backends.

anntzer · anntzer · commit 8fdc2ad5829b · 2023-07-03T19:08:32.000+02:00
It can easily be inlined and is clearly a helper API for savefig (it explicitly copies the _is_saving private attribute), which has been made mostly unnecessary since 8159c81 (nearly 10y ago).
diff --git a/doc/api/next_api_changes/deprecations/26241-AL.rst b/doc/api/next_api_changes/deprecations/26241-AL.rst
@@ -0,0 +1,3 @@
+``FigureCanvasBase.switch_backends``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+... is deprecated with no replacement.
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -2013,19 +2013,19 @@ def _switch_canvas_and_return_print_method(self, fmt, backend=None):
             if not hasattr(canvas_class, f"print_{fmt}"):
                 raise ValueError(
                     f"The {backend!r} backend does not support {fmt} output")
+            canvas = canvas_class(self.figure)
         elif hasattr(self, f"print_{fmt}"):
             # Return the current canvas if it supports the requested format.
             canvas = self
-            canvas_class = None  # Skip call to switch_backends.
         else:
             # Return a default canvas for the requested format, if it exists.
             canvas_class = get_registered_canvas_class(fmt)
-        if canvas_class:
-            canvas = self.switch_backends(canvas_class)
-        if canvas is None:
-            raise ValueError(
-                "Format {!r} is not supported (supported formats: {})".format(
-                    fmt, ", ".join(sorted(self.get_supported_filetypes()))))
+            if canvas_class is None:
+                raise ValueError(
+                    "Format {!r} is not supported (supported formats: {})".format(
+                        fmt, ", ".join(sorted(self.get_supported_filetypes()))))
+            canvas = canvas_class(self.figure)
+        canvas._is_saving = self._is_saving
         meth = getattr(canvas, f"print_{fmt}")
         mod = (meth.func.__module__
                if hasattr(meth, "func")  # partialmethod, e.g. backend_wx.
@@ -2214,6 +2214,7 @@ def get_default_filename(self):
         filename = basename + '.' + filetype
         return filename
 
+    @_api.deprecated("3.8")
     def switch_backends(self, FigureCanvasClass):
         """
         Instantiate an instance of FigureCanvasClass

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+``FigureCanvasBase.switch_backends``
	`2`	`+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
	`3`	`+... is deprecated with no replacement.`