Don't use Popen(..., shell=True).

QuLogic · QuLogic · commit 90203f5929b6 · 2018-07-10T17:01:41.000-04:00
diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py
@@ -805,7 +805,7 @@ def report_memory(i=0):  # argument may go away
     pid = os.getpid()
     if sys.platform == 'sunos5':
         try:
-            a2 = Popen('ps -p %d -o osz' % pid, shell=True,
+            a2 = Popen(['ps', '-p', '%d' % pid, '-o', 'osz'],
                        stdout=PIPE).stdout.readlines()
         except OSError:
             raise NotImplementedError(
@@ -814,7 +814,7 @@ def report_memory(i=0):  # argument may go away
         mem = int(a2[-1].strip())
     elif sys.platform == 'linux':
         try:
-            a2 = Popen('ps -p %d -o rss,sz' % pid, shell=True,
+            a2 = Popen(['ps', '-p', '%d' % pid, '-o', 'rss,sz'],
                        stdout=PIPE).stdout.readlines()
         except OSError:
             raise NotImplementedError(
@@ -823,7 +823,7 @@ def report_memory(i=0):  # argument may go away
         mem = int(a2[1].split()[1])
     elif sys.platform == 'darwin':
         try:
-            a2 = Popen('ps -p %d -o rss,vsz' % pid, shell=True,
+            a2 = Popen(['ps', '-p', '%d' % pid, '-o', 'rss,vsz'],
                        stdout=PIPE).stdout.readlines()
         except OSError:
             raise NotImplementedError(
