Merge pull request #11417 from jklymak/fix-better-default-spine-path

phobson · web-flow · commit 928d6d5e1a86 · 2018-06-13T12:05:35.000-07:00
FIX: better default spine path (for logit)
diff --git a/lib/matplotlib/spines.py b/lib/matplotlib/spines.py
@@ -481,15 +481,15 @@ def linear_spine(cls, axes, spine_type, **kwargs):
         """
         (staticmethod) Returns a linear :class:`Spine`.
         """
-        # all values of 13 get replaced upon call to set_bounds()
+        # all values of 0.999 get replaced upon call to set_bounds()
         if spine_type == 'left':
-            path = mpath.Path([(0.0, 13), (0.0, 13)])
+            path = mpath.Path([(0.0, 0.999), (0.0, 0.999)])
         elif spine_type == 'right':
-            path = mpath.Path([(1.0, 13), (1.0, 13)])
+            path = mpath.Path([(1.0, 0.999), (1.0, 0.999)])
         elif spine_type == 'bottom':
-            path = mpath.Path([(13, 0.0), (13, 0.0)])
+            path = mpath.Path([(0.999, 0.0), (0.999, 0.0)])
         elif spine_type == 'top':
-            path = mpath.Path([(13, 1.0), (13, 1.0)])
+            path = mpath.Path([(0.999, 1.0), (0.999, 1.0)])
         else:
             raise ValueError('unable to make path for spine "%s"' % spine_type)
         result = cls(axes, spine_type, path, **kwargs)
diff --git a/lib/matplotlib/tests/test_scale.py b/lib/matplotlib/tests/test_scale.py
@@ -17,15 +17,19 @@ def test_log_scales():
 @image_comparison(baseline_images=['logit_scales'], remove_text=True,
                   extensions=['png'])
 def test_logit_scales():
-    ax = plt.figure().add_subplot(111, xscale='logit')
+    fig, ax = plt.subplots()
 
     # Typical extinction curve for logit
     x = np.array([0.001, 0.003, 0.01, 0.03, 0.1, 0.2, 0.3, 0.4, 0.5,
                   0.6, 0.7, 0.8, 0.9, 0.97, 0.99, 0.997, 0.999])
     y = 1.0 / x
 
     ax.plot(x, y)
+    ax.set_xscale('logit')
     ax.grid(True)
+    bbox = ax.get_tightbbox(fig.canvas.get_renderer())
+    assert np.isfinite(bbox.x0)
+    assert np.isfinite(bbox.y0)
 
 
 def test_log_scatter():
