FIX: Don't enable IPython integration if not entering REPL.

Carreau · Carreau · commit 936674b40343 · 2019-08-04T20:48:43.000-07:00
IPython can also be used to simply run files; when this is the case we are not going to be interactive; and we do not want to enable the eventloop integration. Otherwise someone doing: $ ipython script.py Will simply see a window blink, as IPython will exit immediately instead of showing the window and exit. I'm not quite sure how to test that are we basically _want_ something to block forever and wait for user input; so no test added Closes: ipython/ipython#11837
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -1553,6 +1553,20 @@ def _draw(renderer): raise Done(renderer)
             return figure._cachedRenderer
 
 
+def is_non_interactive_terminal_ipython(ip):
+    """
+    Return whether we are in a a terminal IPython, but non interactive.
+
+    When in _terminal_ IPython, ip.parent will have and `interact` attribute,
+    if this attribute is False we do not setup eventloop integration as the
+    user will _not_ interact with IPython. In all other case (ZMQKernel, or is
+    interactive), we do.
+    """
+    return (hasattr(ip, 'parent')
+        and (ip.parent is not None)
+        and getattr(ip.parent, 'interact', None) is False)
+
+
 class FigureCanvasBase:
     """
     The canvas the figure renders into.
@@ -1649,9 +1663,13 @@ def _fix_ipython_backend2gui(cls):
             # Work around pylabtools.find_gui_and_backend always reading from
             # rcParamsOrig.
             orig_origbackend = mpl.rcParamsOrig["backend"]
+
             try:
                 mpl.rcParamsOrig["backend"] = mpl.rcParams["backend"]
-                ip.enable_matplotlib()
+                if is_non_interactive_terminal_ipython(ip):
+                    pass
+                else:
+                    ip.enable_matplotlib()
             finally:
                 mpl.rcParamsOrig["backend"] = orig_origbackend
 
