MNT: make local variable const

tacaswell · tacaswell · commit 9729ac26465b · 2020-01-22T22:11:51.000-08:00
To make clear we won't be changing them.
diff --git a/src/_path.h b/src/_path.h
@@ -857,19 +857,19 @@ inline bool segments_intersect(const double &x1,
                        (fmin(x3, x4) <= fmin(x1, x2) && fmin(x1, x2) <= fmax(x3, x4));
             }
         }
-       
+
         return false;
     }
 
-    double n1 = ((x4 - x3) * (y1 - y3)) - ((y4 - y3) * (x1 - x3));
-    double n2 = ((x2 - x1) * (y1 - y3)) - ((y2 - y1) * (x1 - x3));
+    const double n1 = ((x4 - x3) * (y1 - y3)) - ((y4 - y3) * (x1 - x3));
+    const double n2 = ((x2 - x1) * (y1 - y3)) - ((y2 - y1) * (x1 - x3));
 
-    double u1 = n1 / den;
-    double u2 = n2 / den;
+    const double u1 = n1 / den;
+    const double u2 = n2 / den;
 
-    return ((u1 > 0.0 || isclose(u1, 0.0, rtol, atol)) && 
-            (u1 < 1.0 || isclose(u1, 1.0, rtol, atol)) && 
-            (u2 > 0.0 || isclose(u2, 0.0, rtol, atol)) && 
+    return ((u1 > 0.0 || isclose(u1, 0.0, rtol, atol)) &&
+            (u1 < 1.0 || isclose(u1, 1.0, rtol, atol)) &&
+            (u2 > 0.0 || isclose(u2, 0.0, rtol, atol)) &&
             (u2 < 1.0 || isclose(u2, 1.0, rtol, atol)));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -857,19 +857,19 @@ inline bool segments_intersect(const double &x1,`
`857`	`857`	`(fmin(x3, x4) <= fmin(x1, x2) && fmin(x1, x2) <= fmax(x3, x4));`
`858`	`858`	`}`
`859`	`859`	`}`
`860`		`-`
	`860`	`+`
`861`	`861`	`return false;`
`862`	`862`	`}`
`863`	`863`
`864`		`- double n1 = ((x4 - x3) * (y1 - y3)) - ((y4 - y3) * (x1 - x3));`
`865`		`- double n2 = ((x2 - x1) * (y1 - y3)) - ((y2 - y1) * (x1 - x3));`
	`864`	`+ const double n1 = ((x4 - x3) * (y1 - y3)) - ((y4 - y3) * (x1 - x3));`
	`865`	`+ const double n2 = ((x2 - x1) * (y1 - y3)) - ((y2 - y1) * (x1 - x3));`
`866`	`866`
`867`		`- double u1 = n1 / den;`
`868`		`- double u2 = n2 / den;`
	`867`	`+ const double u1 = n1 / den;`
	`868`	`+ const double u2 = n2 / den;`
`869`	`869`
`870`		`- return ((u1 > 0.0 \|\| isclose(u1, 0.0, rtol, atol)) &&`
`871`		`- (u1 < 1.0 \|\| isclose(u1, 1.0, rtol, atol)) &&`
`872`		`- (u2 > 0.0 \|\| isclose(u2, 0.0, rtol, atol)) &&`
	`870`	`+ return ((u1 > 0.0 \|\| isclose(u1, 0.0, rtol, atol)) &&`
	`871`	`+ (u1 < 1.0 \|\| isclose(u1, 1.0, rtol, atol)) &&`
	`872`	`+ (u2 > 0.0 \|\| isclose(u2, 0.0, rtol, atol)) &&`
`873`	`873`	`(u2 < 1.0 \|\| isclose(u2, 1.0, rtol, atol)));`
`874`	`874`	`}`
`875`	`875`