Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 977955c

Browse files
committed
Pin to oldest supported PyQt on minver CI instance.
This will be relevant once we also include PyQt6 support, as details of enum access have changed in PyQt 5.11. PyQt is not actually a dependency so I don't think we can use the constraints file (minver.txt) for that.
1 parent 6530db1 commit 977955c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
os: ubuntu-16.04
2626
python-version: 3.7
2727
extra-requirements: '-c requirements/testing/minver.txt'
28+
pyqt5-ver: 5.8 # oldest version with a Py3.7 wheel.
2829
delete-font-cache: true
2930
XVFB_RUN: xvfb-run -a
3031
- os: ubuntu-16.04
@@ -168,7 +169,7 @@ jobs:
168169
# Sept 2020) for either pyqt5 (there are only wheels for 10.13+) or
169170
# pyside2 (the latest version (5.13.2) with 10.12 wheels has a
170171
# fatal to us bug, it was fixed in 5.14.0 which has 10.13 wheels)
171-
python -mpip install --upgrade pyqt5 &&
172+
python -mpip install --upgrade pyqt5${{ matrix.pyqt5-ver }} &&
172173
python -c 'import PyQt5.QtCore' &&
173174
echo 'PyQt5 is available' ||
174175
echo 'PyQt5 is not available'

0 commit comments

Comments
 (0)