Rename functions in determinism.py to remove `test' keyword, since these are not main testing functions.

Alexis Bienvenüe · Alexis Bienvenüe · commit 995173d6ef9a · 2016-10-04T11:15:09.000+02:00
diff --git a/lib/matplotlib/testing/determinism.py b/lib/matplotlib/testing/determinism.py
@@ -9,7 +9,7 @@
 from matplotlib import pyplot as plt
 
 
-def _test_determinism_save(filename, objects='mhi', format="pdf"):
+def _determinism_save(filename, objects='mhi', format="pdf"):
     # save current value of SOURCE_DATE_EPOCH and set it
     # to a constant value, so that time difference is not
     # taken into account
@@ -60,7 +60,7 @@ def _test_determinism_save(filename, objects='mhi', format="pdf"):
         os.environ['SOURCE_DATE_EPOCH'] = sde
 
 
-def _test_determinism(objects='mhi', format="pdf", uid=""):
+def _determinism_check(objects='mhi', format="pdf", uid=""):
     """
     Output three times the same graphs and checks that the outputs are exactly
     the same.
@@ -87,8 +87,8 @@ def _test_determinism(objects='mhi', format="pdf", uid=""):
                     'import matplotlib; '
                     'matplotlib.use(%r); '
                     'from matplotlib.testing.determinism '
-                    'import _test_determinism_save;'
-                    '_test_determinism_save(%r,%r,%r)'
+                    'import _determinism_save;'
+                    '_determinism_save(%r,%r,%r)'
                     % (format, filename, objects, format)])
         with open(filename, 'rb') as fd:
             plots.append(fd.read())
@@ -97,7 +97,7 @@ def _test_determinism(objects='mhi', format="pdf", uid=""):
         assert_equal(p, plots[0])
 
 
-def _test_source_date_epoch(format, string, keyword=b"CreationDate"):
+def _determinism_source_date_epoch(format, string, keyword=b"CreationDate"):
     """
     Test SOURCE_DATE_EPOCH support. Output a document with the envionment
     variable SOURCE_DATE_EPOCH set to 2000-01-01 00:00 UTC and check that the
@@ -121,8 +121,8 @@ def _test_source_date_epoch(format, string, keyword=b"CreationDate"):
                 'import matplotlib; '
                 'matplotlib.use(%r); '
                 'from matplotlib.testing.determinism '
-                'import _test_determinism_save;'
-                '_test_determinism_save(%r,%r,%r)'
+                'import _determinism_save;'
+                '_determinism_save(%r,%r,%r)'
                 % (format, filename, "", format)])
     find_keyword = re.compile(b".*" + keyword + b".*")
     with open(filename, 'rb') as fd:
diff --git a/lib/matplotlib/tests/test_backend_pdf.py b/lib/matplotlib/tests/test_backend_pdf.py
@@ -12,8 +12,8 @@
 from matplotlib import cm, rcParams
 from matplotlib.backends.backend_pdf import PdfPages
 from matplotlib import pyplot as plt
-from matplotlib.testing.determinism import (_test_source_date_epoch,
-                                            _test_determinism)
+from matplotlib.testing.determinism import (_determinism_source_date_epoch,
+                                            _determinism_check)
 from matplotlib.testing.decorators import (image_comparison, knownfailureif,
                                            cleanup)
 
@@ -114,37 +114,37 @@ def test_composite_image():
 @cleanup
 def test_source_date_epoch():
     """Test SOURCE_DATE_EPOCH support for PDF output"""
-    _test_source_date_epoch("pdf", b"/CreationDate (D:20000101000000Z)")
+    _determinism_source_date_epoch("pdf", b"/CreationDate (D:20000101000000Z)")
 
 
 @cleanup
 def test_determinism_plain():
     """Test for reproducible PDF output: simple figure"""
-    _test_determinism('', format="pdf")
+    _determinism_check('', format="pdf")
 
 
 @cleanup
 def test_determinism_images():
     """Test for reproducible PDF output: figure with different images"""
-    _test_determinism('i', format="pdf")
+    _determinism_check('i', format="pdf")
 
 
 @cleanup
 def test_determinism_hatches():
     """Test for reproducible PDF output: figure with different hatches"""
-    _test_determinism('h', format="pdf")
+    _determinism_check('h', format="pdf")
 
 
 @cleanup
 def test_determinism_markers():
     """Test for reproducible PDF output: figure with different markers"""
-    _test_determinism('m', format="pdf")
+    _determinism_check('m', format="pdf")
 
 
 @cleanup
 def test_determinism_all():
     """Test for reproducible PDF output"""
-    _test_determinism(format="pdf")
+    _determinism_check(format="pdf")
 
 
 @image_comparison(baseline_images=['hatching_legend'],
diff --git a/lib/matplotlib/tests/test_backend_ps.py b/lib/matplotlib/tests/test_backend_ps.py
@@ -11,8 +11,8 @@
 import matplotlib
 import matplotlib.pyplot as plt
 from matplotlib import patheffects
-from matplotlib.testing.determinism import (_test_source_date_epoch,
-                                            _test_determinism)
+from matplotlib.testing.determinism import (_determinism_source_date_epoch,
+                                            _determinism_check)
 from matplotlib.testing.decorators import cleanup, knownfailureif
 
 
@@ -183,13 +183,14 @@ def test_source_date_epoch():
     # because the produced timestamp comes from ghostscript:
     # %%CreationDate: D:20000101000000Z00\'00\', and this could change
     # with another ghostscript version.
-    _test_source_date_epoch("ps", b"%%CreationDate: Sat Jan 01 00:00:00 2000")
+    _determinism_source_date_epoch(
+        "ps", b"%%CreationDate: Sat Jan 01 00:00:00 2000")
 
 
 @cleanup
 def test_determinism_all():
     """Test for reproducible PS output"""
-    _test_determinism(format="ps")
+    _determinism_check(format="ps")
 
 
 @cleanup
@@ -198,7 +199,7 @@ def test_determinism_all():
 def test_determinism_all_tex():
     """Test for reproducible PS/tex output"""
     matplotlib.rcParams['text.usetex'] = True
-    _test_determinism(format="ps", uid="_tex")
+    _determinism_check(format="ps", uid="_tex")
 
 
 if __name__ == '__main__':
