No need to remove figure.show when pickling.

anntzer · anntzer · commit 999ac717e073 · 2020-01-13T23:57:24.000+01:00
We stopped monkeypatching figure.show on the figure instance in 51ffd4b.
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -1622,7 +1622,7 @@ def _break_share_link(ax, grouper):
             return None
 
         self._axstack.remove(ax)
-        self._axobservers.process("_on_axes_change", self)
+        self._axobservers.process("_axes_change_event", self)
         self.stale = True
 
         last_ax = _break_share_link(ax, ax._shared_y_axes)
@@ -1918,7 +1918,7 @@ def gca(self, **kwargs):
     def sca(self, a):
         """Set the current axes to be *a* and return *a*."""
         self._axstack.bubble(a)
-        self._axobservers.process("_on_axes_change", self)
+        self._axobservers.process("_axes_change_event", self)
         return a
 
     def _gci(self):
@@ -1961,7 +1961,7 @@ def __getstate__(self):
         # The canvas cannot currently be pickled, but this has the benefit
         # of meaning that a figure can be detached from one canvas, and
         # re-attached to another.
-        for attr_to_pop in ('show', 'canvas', '_cachedRenderer'):
+        for attr_to_pop in ('canvas', '_cachedRenderer'):
             state.pop(attr_to_pop, None)
 
         # add version information to the state
@@ -2028,7 +2028,7 @@ def add_axobserver(self, func):
         """Whenever the axes state change, ``func(self)`` will be called."""
         # Connect a wrapper lambda and not func itself, to avoid it being
         # weakref-collected.
-        self._axobservers.connect("_on_axes_change", lambda arg: func(arg))
+        self._axobservers.connect("_axes_change_event", lambda arg: func(arg))
 
     def savefig(self, fname, *, transparent=None, **kwargs):
         """
