Remove mlab.identity

dstansby · dstansby · commit 9b81fd28b67f · 2018-09-29T11:05:09.000+01:00
diff --git a/doc/api/next_api_changes/2018-09-18-DS.rst b/doc/api/next_api_changes/2018-09-18-DS.rst
@@ -12,6 +12,7 @@ in Matplotlib 2.2 has been removed. See below for a list:
 - `mlab.l2norm` (use ``numpy.linalg.norm(a, ord=2)`` instead)
 - `mlab.norm_flat` (use ``numpy.linalg.norm(a.flat, ord=2)`` instead)
 - `mlab.frange` (use numpy.arange instead)
+- `mlab.identity` (use numpy.identity instead)
 - `mlab.cohere_pairs` (use scipy.signal.coherence instead)
 - `mlab.entropy` (use scipy.stats.entropy instead)
 - `mlab.normpdf` (use scipy.stats.norm.pdf instead)
diff --git a/lib/matplotlib/mlab.py b/lib/matplotlib/mlab.py
@@ -1247,33 +1247,6 @@ def movavg(x, n):
 """
 
 
-@cbook.deprecated("2.2", 'numpy.identity')
-def identity(n, rank=2, dtype='l', typecode=None):
-    """
-    Returns the identity matrix of shape (*n*, *n*, ..., *n*) (rank *r*).
-
-    For ranks higher than 2, this object is simply a multi-index Kronecker
-    delta::
-
-                            /  1  if i0=i1=...=iR,
-        id[i0,i1,...,iR] = -|
-                            \\  0  otherwise.
-
-    Optionally a *dtype* (or typecode) may be given (it defaults to 'l').
-
-    Since rank defaults to 2, this function behaves in the default case (when
-    only *n* is given) like ``numpy.identity(n)`` -- but surprisingly, it is
-    much faster.
-    """
-    if typecode is not None:
-        dtype = typecode
-    iden = np.zeros((n,)*rank, dtype)
-    for i in range(n):
-        idx = (i,)*rank
-        iden[idx] = 1
-    return iden
-
-
 @cbook.deprecated("2.2")
 def base_repr(number, base=2, padding=0):
     """
diff --git a/lib/matplotlib/pylab.py b/lib/matplotlib/pylab.py
@@ -231,7 +231,7 @@
 from matplotlib.mlab import (
     base_repr, binary_repr, csv2rec,
     demean, detrend, detrend_linear, detrend_mean, detrend_none,
-    identity, ispower2, isvector,
+    ispower2, isvector,
     log2, movavg,
     window_hanning, window_none)
 
