MNT: copy unscaled dash data in update_from

tacaswell · tacaswell · commit 9fb4f9bba510 · 2017-01-14T21:22:31.000-05:00
As part of scaling dashes with linewidth, unscaled versions of
the dash pattern are now tracked.  Make sure we copy these as well.
diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
@@ -788,6 +788,7 @@ def update_from(self, other):
         self._facecolors = other._facecolors
         self._linewidths = other._linewidths
         self._linestyles = other._linestyles
+        self._us_linestyles = other._us_linestyles
         self._pickradius = other._pickradius
         self._hatch = other._hatch
 
diff --git a/lib/matplotlib/lines.py b/lib/matplotlib/lines.py
@@ -1319,7 +1319,9 @@ def update_from(self, other):
         self._markeredgecolor = other._markeredgecolor
         self._markeredgewidth = other._markeredgewidth
         self._dashSeq = other._dashSeq
+        self._us_dashSeq = other._us_dashSeq
         self._dashOffset = other._dashOffset
+        self._us_dashOffset = other._us_dashOffset
         self._dashcapstyle = other._dashcapstyle
         self._dashjoinstyle = other._dashjoinstyle
         self._solidcapstyle = other._solidcapstyle
diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
@@ -199,9 +199,9 @@ def update_from(self, other):
         self._facecolor = other._facecolor
         self._fill = other._fill
         self._hatch = other._hatch
-        self._linewidth = other._linewidth
-        # Use setters, getters where we need the extra work they do.
-        self.set_linestyle(other._linestyle)  # also sets dash properties
+        # copy the unscaled dash pattern
+        self._us_dashes = other._us_dashes
+        self.set_linewidth(other._linewidth)  # also sets dash properties
         self.set_transform(other.get_data_transform())
 
     def get_extents(self):
