Merge pull request #2357 from ChrisBeaumont/empty-shared

dmcdougall · dmcdougall · commit a091f6d1ba96 · 2013-08-31T15:56:05.000-07:00
Better axis limits when using shared axes and empty subplots
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -1895,6 +1895,11 @@ def autoscale_view(self, tight=None, scalex=True, scaley=True):
         if scalex and self._autoscaleXon:
             xshared = self._shared_x_axes.get_siblings(self)
             dl = [ax.dataLim for ax in xshared]
+            #ignore non-finite data limits if good limits exist
+            finite_dl = [d for d in dl if np.isfinite(d).all()]
+            if len(finite_dl):
+                dl = finite_dl
+
             bb = mtransforms.BboxBase.union(dl)
             x0, x1 = bb.intervalx
             xlocator = self.xaxis.get_major_locator()
@@ -1916,6 +1921,11 @@ def autoscale_view(self, tight=None, scalex=True, scaley=True):
         if scaley and self._autoscaleYon:
             yshared = self._shared_y_axes.get_siblings(self)
             dl = [ax.dataLim for ax in yshared]
+            #ignore non-finite data limits if good limits exist
+            finite_dl = [d for d in dl if np.isfinite(d).all()]
+            if len(finite_dl):
+                dl = finite_dl
+
             bb = mtransforms.BboxBase.union(dl)
             y0, y1 = bb.intervaly
             ylocator = self.yaxis.get_major_locator()
@@ -3257,5 +3267,3 @@ def get_shared_x_axes(self):
     def get_shared_y_axes(self):
         'Return a copy of the shared axes Grouper object for y axes'
         return self._shared_y_axes
-
-
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -1708,6 +1708,19 @@ def test_vline_limit():
     assert ymax == 0.25
 
 
+@cleanup
+def test_empty_shared_subplots():
+    #empty plots with shared axes inherit limits from populated plots
+    fig, axes = plt.subplots(nrows=1, ncols=2, sharex=True, sharey=True)
+    axes[0].plot([1,2,3], [2, 4, 6])
+    x0, x1 = axes[1].get_xlim()
+    y0, y1 = axes[1].get_ylim()
+    assert x0 <= 1
+    assert x1 >= 3
+    assert y0 <= 2
+    assert y1 >= 6
+
+
 if __name__ == '__main__':
     import nose
     nose.runmodule(argv=['-s', '--with-doctest'], exit=False)
