Fix pandas DataFrame align center (#8785)

ryanlaclair · anntzer · commit a19ed84c1205 · 2017-07-01T16:56:42.000-07:00
* Added test for issue 8767

* Fix for issue 8767

* simplified test and added test for barh

* added fig.canvas.draw to make sure rendering completes
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -2070,10 +2070,9 @@ def make_iterable(x):
 
         if align == 'center':
             if orientation == 'vertical':
-                left = [left[i] - width[i] / 2. for i in xrange(len(left))]
+                left = [l - w / 2. for l, w in zip(left, width)]
             elif orientation == 'horizontal':
-                bottom = [bottom[i] - height[i] / 2.
-                          for i in xrange(len(bottom))]
+                bottom = [b - h / 2. for b, h in zip(bottom, height)]
 
         elif align != 'edge':
             raise ValueError('invalid alignment: %s' % align)
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -4863,6 +4863,36 @@ def test_pandas_indexing_hist():
     axes.hist(ser_2)
 
 
+def test_pandas_bar_align_center():
+    # Tests fix for issue 8767
+    pd = pytest.importorskip('pandas')
+
+    df = pd.DataFrame({'a': range(2), 'b': range(2)})
+
+    fig, ax = plt.subplots(1)
+
+    rect = ax.bar(df.loc[df['a'] == 1, 'b'],
+                  df.loc[df['a'] == 1, 'b'],
+                  align='center')
+
+    fig.canvas.draw()
+
+
+def test_pandas_bar_align_center():
+    # Tests fix for issue 8767
+    pd = pytest.importorskip('pandas')
+
+    df = pd.DataFrame({'a': range(2), 'b': range(2)})
+
+    fig, ax = plt.subplots(1)
+
+    rect = ax.barh(df.loc[df['a'] == 1, 'b'],
+                   df.loc[df['a'] == 1, 'b'],
+                   align='center')
+
+    fig.canvas.draw()
+
+
 def test_axis_set_tick_params_labelsize_labelcolor():
     # Tests fix for issue 4346
     axis_1 = plt.subplot()
