testing: baseline images now in svn. specify image names without '.png'

astraw · astraw · commit a1af04fa4452 · 2009-09-06T22:46:00.000Z
svn path=/trunk/matplotlib/; revision=7665
diff --git a/lib/matplotlib/testing/decorators.py b/lib/matplotlib/testing/decorators.py
@@ -1,8 +1,8 @@
 from matplotlib.testing.noseclasses import KnownFailureTest, \
      KnownFailureDidNotFailTest, ImageComparisonFailure
-import sys
+import os, sys
 import nose
-from matplotlib.cbook import get_sample_data
+import matplotlib.tests
 from matplotlib.testing.compare import compare_images
 
 def knownfailureif(fail_condition, msg=None):
@@ -36,7 +36,7 @@ def failer(*args, **kwargs):
         return nose.tools.make_decorator(f)(failer)
     return known_fail_decorator
 
-def image_comparison(baseline_images=None, tol=1e-3):
+def image_comparison(baseline_images=None):
     """
     compare images generated by the test with those specified in
     *baseline_images*, which must correspond within tolerance *tol*,
@@ -49,10 +49,22 @@ def image_comparison(baseline_images=None, tol=1e-3):
     def compare_images_decorator(func):
         def decorated_compare_images(*args,**kwargs):
             result = func(*args,**kwargs)
+            extension = '.png' # TODO: test more backends
             for fname in baseline_images:
-                actual = fname
-                expected = get_sample_data('test_baseline_%s'%fname,
-                                           asfileobj=False)
+                actual = fname + extension
+
+                # compute filename for baseline image
+                module_name = func.__module__
+                mods = module_name.split('.')
+                assert mods.pop(0)=='matplotlib'
+                assert mods.pop(0)=='tests'
+                subdir = '/'.join(mods)
+                basedir = os.path.dirname(matplotlib.tests.__file__)
+                baseline_dir = os.path.join(basedir,'baseline_images',subdir)
+                expected = os.path.join(baseline_dir,fname) + extension
+
+                # compare the images
+                tol=1e-3 # default tolerance
                 err = compare_images( expected, actual, tol,
                                       in_decorator=True )
                 if err:
diff --git a/lib/matplotlib/tests/test_spines.py b/lib/matplotlib/tests/test_spines.py
@@ -3,7 +3,7 @@
 from matplotlib.testing.decorators import image_comparison
 import matplotlib.pyplot as plt
 
-@image_comparison(baseline_images=['spines_axes_positions.png'])
+@image_comparison(baseline_images=['spines_axes_positions'])
 def test_spines_axes_positions():
     # SF bug 2852168
     fig = plt.figure()
@@ -18,4 +18,4 @@ def test_spines_axes_positions():
     ax.xaxis.set_ticks_position('top')
     ax.spines['left'].set_color('none')
     ax.spines['bottom'].set_color('none')
-    fig.savefig('spines_axes_positions.png')
+    fig.savefig('spines_axes_positions')
diff --git a/setup.py b/setup.py
@@ -101,6 +101,18 @@
                               'backends/Matplotlib.nib/*',
                               ]}
 
+if 1:
+    # TODO: exclude these when making release?
+    baseline_images = glob.glob(os.path.join('lib','matplotlib','tests',
+                                             'baseline_images','*','*'))
+    def chop_package(fname):
+        badstr = os.path.join('lib','matplotlib','')
+        assert fname.startswith(badstr)
+        result = fname[ len(badstr): ]
+        return result
+    baseline_images = [chop_package(f) for f in baseline_images]
+    package_data['matplotlib'].extend(baseline_images)
+
 if not check_for_numpy():
     sys.exit(1)
 
